Integrating Dflow Declarative Swaps with Helium Wallet#857
Draft
rzalovDflow wants to merge 16 commits into
Draft
Integrating Dflow Declarative Swaps with Helium Wallet#857rzalovDflow wants to merge 16 commits into
rzalovDflow wants to merge 16 commits into
Conversation
* Design tokens (helium#809) * Progress * Fix lint * Fix lint * Remove light theme * Fix some colors * More progress * Bump major and fix fastlane * Fix onboarding and more UI tweaks * Fix service sheet title * Fix hotspot and payment screens * Show wallet service by default * Fix initial wallet balance on load * Fix governance screens * More fixes * Fix more lint * More fixes * More fixes * More fixes * More fixes :) * Fix Account page nav and collectables fetching * Fix lint * Fix HNT keyboard * Fix text transform * Fix scoll boxes on android * Cache tokens * Fix voter screens * More UI fixes * Fix refresh control and transfer assets * Fix address book and lock tokens preview * Fix crash in nft list when no approved collections are present * Fix sheets * Move map ledged up off curve * Add animated balance text * Add VirtualizedLists to ignore log * Fix balance text color and pin screen font * Animate fractionals in balance text * More fixes * Rebase and address comments --------- Co-authored-by: bry <bryanzettler@gmail.com>
* fix: fix keystone account assign screen ui * fix: remove unused code when reimport account * fix: fix text color * chore: refactor keystone reimport accounts logic --------- Co-authored-by: ZhenQian <zhenqian@keyst.one>
* bump deps (helium#821) * bump deps 0.9.12 (helium#822) * Fix getPositionKeysForOwner args (helium#823) * Fix bug when claiming all with custom destination --------- Co-authored-by: Bryan <bryanzettler@gmail.com>
* Hotspot onboarding v3 * Update IOT onboarding * Fix lint * Remove maplibre patch * Add lat,lng, and elevation when onboarding IOT * Fix lint and fix app structure * Fix lint * Add connect via bluetooth screen * Fix keyboard in iot onboarding * Allow user to skip if wifi is configured * Attempt to fix error showing up by default for scan * Fix delegate screen
* bump deps (helium#821) * bump deps 0.9.12 (helium#822) * Fix getPositionKeysForOwner args (helium#823) * 2.10.1 * update hooks to use prop conditional when fetching new output (helium#824) * Fix bug when claiming all with custom destination (helium#832) * Show jupiter error before tx error --------- Co-authored-by: Bryan <bryanzettler@gmail.com>
* New onboarding * Fix lint * Add new splash screen * Disable mobile onboarding * Address comments
* Add missing sequentially (helium#837) * fix (helium#840) * fix * better logic for expired * tweak * bump deps 0.9.18 (helium#841) * Take a refactor pass on SwapScreen (helium#845) --------- Co-authored-by: Noah Prince <83885631+ChewingGlass@users.noreply.github.com>
* Add provider method deeplinks * Provider method fixes * Address comments, fix small screen issues, lat,lng, and more :) * fix lint * Rebase * enable mobile onboarding
…ded flow to useSubmitTx
Perronef5
requested changes
Feb 2, 2025
Contributor
Perronef5
left a comment
Perronef5
left a comment
There was a problem hiding this comment.
Some concerns here. Please attach a demo for iOS and Android. Thanks! 🙂
| "@babel/preset-typescript": "7.21.0", | ||
| "@bonfida/spl-name-service": "1.1.1", | ||
| "@coral-xyz/anchor": "0.28.0", | ||
| "@dflow-protocol/swap-api-utils": "^0.1.2", |
Contributor
There was a problem hiding this comment.
All dependencies must be pinned. Please pin 🙂. Thanks!
| } from 'react' | ||
| import * as Logger from '@utils/logger' | ||
|
|
||
| const AGGREGATOR_API_BASE_URL = 'https://quote-api.dflow.net' |
Contributor
There was a problem hiding this comment.
Can this go into a constants file?
| ) | ||
|
|
||
| if (!response.ok) { | ||
| throw new Error(`Failed to get quote: ${response.statusText}`) |
Contributor
There was a problem hiding this comment.
Can we add this to the en.ts file
| const signIntent = useCallback( | ||
| async (intentData: Intent): Promise<Transaction> => { | ||
| if (!intentData.openTransaction) { | ||
| throw new Error('No open transaction found in intent data') |
Contributor
There was a problem hiding this comment.
This should go in the en.ts file
Contributor
There was a problem hiding this comment.
Why was the Jupiter provider deleted?
| case ORDER_STATUS.CLOSED: { | ||
| if (result.fills.length > 0) { | ||
| setSuccess(true) | ||
| setTimeout(() => navigation.goBack(), 2000) |
Contributor
There was a problem hiding this comment.
A set timeout seems like it will not always work. Why do we need this?
| const solanaPayment = useSelector( | ||
| (reduxState: RootState) => reduxState.solana.payment, | ||
| ) | ||
| useEffect(() => { |
Contributor
There was a problem hiding this comment.
Having this monitor in the use effect may lock the UI thread
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrating Dflow Declarative Swaps with Helium Wallet