DS-2521 : updated delete job to trigger batch and tag objects for cleanup - #1894
Open
yogeshdhariyal wants to merge 13 commits into
Open
DS-2521 : updated delete job to trigger batch and tag objects for cleanup#1894yogeshdhariyal wants to merge 13 commits into
yogeshdhariyal wants to merge 13 commits into
Conversation
…ration to clean up Signed-off-by: Yogesh Dhariyal <yogesh.dhariyal@here.com>
Signed-off-by: Yogesh Dhariyal <yogesh.dhariyal@here.com>
Signed-off-by: Yogesh Dhariyal <yogesh.dhariyal@here.com>
Signed-off-by: Yogesh Dhariyal <yogesh.dhariyal@here.com>
Signed-off-by: Yogesh Dhariyal <yogesh.dhariyal@here.com>
Signed-off-by: Yogesh Dhariyal <yogesh.dhariyal@here.com>
Signed-off-by: Yogesh Dhariyal <yogesh.dhariyal@here.com>
roegi
requested changes
Aug 6, 2026
|
|
||
| private Future<Void> scheduleResourcesForDeletion() { | ||
| return ASYNC.run(() -> { | ||
| boolean plainJob = !hasRegisterDataReferencesStep() && !isReleaseJob(); |
Contributor
There was a problem hiding this comment.
This differentiation is not necessary anymore. It was just a temporary check, that was necessary when references were still pointing to the job Api bucket
| */ | ||
| public static List<String> collectInputPrefixesForDeletion(String jobId) { | ||
| List<String> prefixes = Collections.synchronizedList(new ArrayList<>()); | ||
| if (loadAllInputSetNames(jobId).isEmpty()) { |
Contributor
There was a problem hiding this comment.
No need to delete input set by input set. Just delete the whole inputs folder of that job if it's not re-used by some other job (checked in the metadata)
| prefixes = new ArrayList<>(Input.collectInputPrefixesForDeletion(getId())); | ||
| //Outputs are never shared across jobs; delete each step's outputs (unless registered references / a release job). | ||
| if (plainJob) | ||
| getSteps().stepStream().forEach(step -> prefixes.add(step.getOutputS3Prefix())); |
Contributor
There was a problem hiding this comment.
No need to delete output set by output set. Just delete the whole outputs top-level folder all at once
Signed-off-by: Yogesh Dhariyal <yogesh.dhariyal@here.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.