Skip to content

Fix partial repository creation - #53

Open
jpiron wants to merge 2 commits into
idealista:developfrom
jpiron:fix_partial_repository_creation
Open

Fix partial repository creation#53
jpiron wants to merge 2 commits into
idealista:developfrom
jpiron:fix_partial_repository_creation

Conversation

@jpiron

@jpiron jpiron commented Nov 24, 2020

Copy link
Copy Markdown
Contributor

Description of the Change

Fix partial repository (repositories that don't declare all 3 proxy, group, hosted types) creations.

Benefits

Whoever wants to create partial repositories.

Possible Drawbacks

None I am aware of.

Applicable Issues

None.

@vicsufer

Copy link
Copy Markdown
Contributor

Looks good to me 👍

@vicsufer vicsufer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpiron It seems that builds fails:
For Debian Buster because nexus service is not starting. https://travis-ci.com/github/idealista/nexus-role/jobs/446245631
For Debian Stretch you probably need to update Goss tests with the new partial configurations. https://travis-ci.com/github/idealista/nexus-role/jobs/446245630

@jpiron
jpiron force-pushed the fix_partial_repository_creation branch from d7f4606 to 0822943 Compare November 24, 2020 14:34
@jpiron

jpiron commented Nov 24, 2020

Copy link
Copy Markdown
Contributor Author

I updated the Goss tests.
As for the service not starting for Debian Buster I am not really sure why. It works when I execute the tests locally.

@vicsufer

vicsufer commented Nov 24, 2020

Copy link
Copy Markdown
Contributor

Molecule tests use debian stretch by default, try chaning the image to idealista/jdk:8u265-buster-adoptopenjdk-headless which is the one in use on travis.
https://github.com/idealista/nexus-role/blob/develop/molecule/default/molecule.yml#L12

@jpiron

jpiron commented Nov 24, 2020

Copy link
Copy Markdown
Contributor Author

That's what I did.
I ran DOCKER_IMAGE_BASE=idealista/jdk:8u265-buster-adoptopenjdk-headless molecule test --all without any error.

Repositories might not declare all 3 types (proxy, hosted, group).
@jpiron
jpiron force-pushed the fix_partial_repository_creation branch from 0822943 to b1887e0 Compare November 30, 2020 20:33
@jpiron

jpiron commented Dec 1, 2020

Copy link
Copy Markdown
Contributor Author

I don't know what more I can do here.
Tests run fine locally and I don't see how the modifications I made could result in nexus service not starting !
Is there any way to retrigger the Travis jobs manually ?

@vicsufer

vicsufer commented Dec 1, 2020

Copy link
Copy Markdown
Contributor

We've been having some troubles with travis, it is up and running now, and your commit is enqueued.
If you want to test with travis by yourself you should be able to enable travis for your fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants