Skip to content

[0.18.0-iap] Remove all contrib extensions#169

Open
suneet-s wants to merge 1 commit into
implydata:0.18.0-iapfrom
suneet-s:0.18.0-iap
Open

[0.18.0-iap] Remove all contrib extensions#169
suneet-s wants to merge 1 commit into
implydata:0.18.0-iapfrom
suneet-s:0.18.0-iap

Conversation

@suneet-s

Copy link
Copy Markdown

Contrib extensions are not packaged with Imply Druid. This will help speed
up build time as we no longer have to compile the extensions only to throw
them away later in the build process.

The only 2 that were packaged in older versions have been removed in 3.3.x
https://github.com/implydata/distribution/blob/1d86be2ebaca32a511fb298f126fd5c3becf006e/src/build/druid#L180

Contrib extensions are not packaged with Imply Druid. This will help speed
up build time as we no longer have to compile the extensions only to throw
them away later in the build process.

The only 2 that were packaged in older versions have been removed in 3.3
https://github.com/implydata/distribution/blob/1d86be2ebaca32a511fb298f126fd5c3becf006e/src/build/druid#L180
@suneet-s suneet-s requested a review from imply-rjenkins July 30, 2020 15:37
@suneet-s

Copy link
Copy Markdown
Author

@imply-rjenkins Will the fact that I removed the bundle contrib extensions profile break something in the distribution repo?

The line I linked to above looks like it's removing an already compiled extension. Can you test if this change works with the distribution repo - or are there any changes needed there as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant