[SYCL][E2E] bindless image - switch tests to immediate command list, etc - #22046
Merged
uditagarwal97 merged 31 commits intoJun 2, 2026
Merged
Conversation
Signed-off-by: Chris Perkins <chris.perkins@intel.com>
Signed-off-by: Chris Perkins <chris.perkins@intel.com>
Signed-off-by: Chris Perkins <chris.perkins@intel.com>
enm-intel
reviewed
May 18, 2026
… and parties Signed-off-by: Chris Perkins <chris.perkins@intel.com>
Merged
uditagarwal97
pushed a commit
that referenced
this pull request
May 19, 2026
Revert "[L0] Use immediate command lists for external semaphore wait/signal (#21930)" This reverts commit e928aae. By putting the semaphore on an immediate command list, but still using the original regular command list for the other graphic operations, we introduce some unsoundness that can lead to races and problems where the regular command list is the default. The better choice in the short term is to simply require that SYCL queues that are intended for semaphore usage use immediate command lists. I have a separate PR (in progress) that will make that change to the docs and tests and introduces a verification. #22046
Signed-off-by: Chris Perkins <chris.perkins@intel.com>
Signed-off-by: Chris Perkins <chris.perkins@intel.com>
github-actions Bot
pushed a commit
to oneapi-src/unified-runtime
that referenced
this pull request
May 20, 2026
Revert "[L0] Use immediate command lists for external semaphore wait/signal (#21930)" This reverts commit e928aaedf443761c54d669f09db8fbf1dabc2ec5. By putting the semaphore on an immediate command list, but still using the original regular command list for the other graphic operations, we introduce some unsoundness that can lead to races and problems where the regular command list is the default. The better choice in the short term is to simply require that SYCL queues that are intended for semaphore usage use immediate command lists. I have a separate PR (in progress) that will make that change to the docs and tests and introduces a verification. intel/llvm#22046
Signed-off-by: Chris Perkins <chris.perkins@intel.com>
Signed-off-by: Chris Perkins <chris.perkins@intel.com>
Signed-off-by: Chris Perkins <chris.perkins@intel.com>
Signed-off-by: Chris Perkins <chris.perkins@intel.com>
…d to change it. Even the AIs are fooled. Signed-off-by: Chris Perkins <chris.perkins@intel.com>
Signed-off-by: Chris Perkins <chris.perkins@intel.com>
Signed-off-by: Chris Perkins <chris.perkins@intel.com>
Signed-off-by: Chris Perkins <chris.perkins@intel.com>
Signed-off-by: Chris Perkins <chris.perkins@intel.com>
Signed-off-by: Chris Perkins <chris.perkins@intel.com>
Signed-off-by: Chris Perkins <chris.perkins@intel.com>
Signed-off-by: Chris Perkins <chris.perkins@intel.com>
cperkinsintel
marked this pull request as ready for review
May 27, 2026 16:09
cperkinsintel
marked this pull request as draft
May 27, 2026 16:09
cperkinsintel
changed the title
cperkinsintel
marked this pull request as ready for review
May 27, 2026 17:19
Contributor
Author
|
ping reviewers @intel/bindless-images-reviewers |
0x12CC
approved these changes
Jun 1, 2026
uditagarwal97
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bindless image semaphores require immediate command lists. This updates the docs and the tests to be aligned with this requirement. Updating the tests with this change means that certain tests that used to fail now pass, so they are are being enabled. Also, some of the failing tests pass with the correct graphic driver, so that expectation is now more explicit in the tests. And, lastly, a few of the tests tripped the validator because they can forget to free a resource if an exception is encountered - fixed that too.