[raft/aux] Add aux Raftstore by MariemBaccari · Pull Request #1528 · interuss/dss

MariemBaccari · 2026-06-15T12:21:00Z

Chained PR: #1622 -> #1528 -> #1626 -> #1597 -> #1623

Implements the aux Raftstore.
Removes the registry as it is not needed by aux which only calls Interact.
Implements the aux repo which calls the consensus instance for each type of operation (except GetDSSAirspaceRepresentationID which is local).

the-glu

95eb833 LGTM

mickmis

Overall LGTM, but several minor comments

mickmis · 2026-08-17T11:41:22Z

+	if locality == "" {
+		return stacktrace.NewErrorWithCode(dsserr.BadRequest, "Locality not set")
+	}
+	if publicEndpoint == "" {
+		return stacktrace.NewErrorWithCode(dsserr.BadRequest, "Public endpoint not set")
+	}


Deduplicate this validation (push it in the caller, or factor away in a separate function, or add a validation middleware, or else) (also from memstore, and also for other methods in here).

mickmis · 2026-08-17T12:17:06Z

+		return stacktrace.Propagate(err, "failed to marshal payload")
+	}
+
+	_, err = r.consensus.HandleClientRequest(ctx, string(saveOwnMetadata), buf, false)


(not for this PR) shouldn't requestType be a type exposed alongside HandleClientRequest?

mickmis · 2026-08-17T12:23:49Z

-func (r *repo) Apply(_ context.Context, _ consensus.Proposal) (any, error) {
-	return nil, stacktrace.NewErrorWithCode(dsserr.NotImplemented, "not implemented yet")
+func (r *repo) Apply(ctx context.Context, proposal consensus.Proposal) (any, error) {
+	memRepo, err := r.memStore.Interact(ctx)


nit: calling Interact here looks like just an unnecessary layer of indirection, since it just returns GetRepo: call GetRepo() directly?

Actually that is making me wonder: do we actually need the memstore abstraction? Don't we only need the memrepo? AKAIU the memstore / memrepo will exclusively be invoked by the raftstore, and never directly by the API layer.
cc @the-glu

I don't think it cost much to keep the abstraction and to keep everything with the same "layering", so that was on purpose yes.

We probably want at some point make the memstore testable directly, or test the raftstore with others kinds of store.

mickmis · 2026-08-17T12:29:58Z

 	return p, nil
 }
+
+func GetClusterID() uint64 {


Why not calling GetConnectParameters instead?

mickmis · 2026-08-17T12:34:25Z

+	Locality       string
+	PublicEndpoint string


Out of clarity, please put the json tags on the fields. This makes it explicit this struct is used for that purpose, and also makes it not necessary to expose them.

Remarks in case of that change it, but we may want to use something else than JSON for future optimizations there.

mickmis · 2026-08-17T12:37:42Z

+	if err != nil {
+		return nil, stacktrace.Propagate(err, "failed to propose %s", getDSSMetadata)
+	}
+	if result == nil {


Is this necessary? The nil returned from HandleClientRequest is actually typed.

mickmis · 2026-08-18T12:26:56Z

+	if _, ok := result.([]*auxmodels.DSSMetadata); !ok {
+		return nil, stacktrace.NewError("unexpected result type: %T", result)


nit

Suggested change

if _, ok := result.([]*auxmodels.DSSMetadata); !ok {

return nil, stacktrace.NewError("unexpected result type: %T", result)

if res, ok := result.([]*auxmodels.DSSMetadata); ok {

return res, nil

MariemBaccari force-pushed the add_aux branch 3 times, most recently from 235e51e to e9ece61 Compare June 15, 2026 13:44

MariemBaccari changed the title ~~[Raft] Add aux stubs~~ [Raft] Add aux Raftstore Jun 15, 2026

MariemBaccari force-pushed the add_aux branch from e9ece61 to 405c203 Compare June 15, 2026 14:43

the-glu reviewed Jun 15, 2026

View reviewed changes

Comment thread pkg/aux_/store/raftstore/store.go Outdated

MariemBaccari force-pushed the add_aux branch 2 times, most recently from 9566c32 to 5d13119 Compare June 15, 2026 14:52

MariemBaccari changed the title ~~[Raft] Add aux Raftstore~~ [raft/aux] Add aux Raftstore Jun 16, 2026

MariemBaccari force-pushed the add_aux branch 5 times, most recently from 8f85bb5 to 9e8af65 Compare June 16, 2026 09:18

MariemBaccari marked this pull request as ready for review June 16, 2026 09:24

MariemBaccari requested a review from the-glu June 16, 2026 09:24

MariemBaccari force-pushed the add_aux branch from 9e8af65 to 95eb833 Compare June 16, 2026 09:45

the-glu approved these changes Jun 16, 2026

View reviewed changes

the-glu mentioned this pull request Jun 16, 2026

[raft] Make raft runnable-locally #1536

Open

barroco added the dss-raft Relating to the application-layer consensus implemenation based on raft label Jun 17, 2026

MariemBaccari force-pushed the add_aux branch 3 times, most recently from 86221f4 to 3739510 Compare June 18, 2026 09:41

This was referenced Jun 18, 2026

[raft/rid] Add rid raftstore subscriptions #1548

Closed

[raft/scd] Add scd Raftstore opintents #1553

Closed

MariemBaccari force-pushed the add_aux branch 2 times, most recently from 3338aeb to 5e0e0cf Compare June 19, 2026 13:46

This was referenced Jun 19, 2026

[raft/scd] Add scd Raftstore availability #1556

Closed

[raft/scd] Add scd Raftstore constraints #1555

Closed

[raft/scd] Add scd Raftstore subscriptions #1554

Closed

MariemBaccari force-pushed the add_aux branch 2 times, most recently from 76cf2b8 to f758781 Compare June 22, 2026 10:04

MariemBaccari force-pushed the add_aux branch 3 times, most recently from 8ce0e32 to 86d5b1a Compare July 10, 2026 11:44

MariemBaccari mentioned this pull request Jul 10, 2026

[raft/aux] Implement aux Raftstore #1582

Closed

MariemBaccari force-pushed the add_aux branch 2 times, most recently from 34be101 to 7d3473a Compare July 10, 2026 12:06

github-project-automation Bot added this to InterUSS Backlog Jul 10, 2026

MariemBaccari force-pushed the add_aux branch 2 times, most recently from f4c3ffb to 447bc05 Compare July 10, 2026 12:16

MariemBaccari mentioned this pull request Aug 10, 2026

[raft][gate 0] Raftstore implementation #1463

Open

MariemBaccari force-pushed the add_aux branch 2 times, most recently from 5bcd009 to 88769b3 Compare August 11, 2026 09:45

[raft/memstore] Add Get and RestoreFrom Snapshot to memstore

b04121e

MariemBaccari force-pushed the add_aux branch from 88769b3 to ee4d690 Compare August 11, 2026 09:51

[raft/aux] Add aux Raftstore

37048f7

MariemBaccari force-pushed the add_aux branch from ee4d690 to 37048f7 Compare August 11, 2026 10:04

This was referenced Aug 11, 2026

[raft/rid] Extract delete subscription #1597

Open

[raft/rid] Raftstore skeleton #1623

Open

[store] json encoding generics #1626

Open

[raft] Pass down locality #1627

Draft

mickmis approved these changes Aug 18, 2026

View reviewed changes

Navigation Menu

Uh oh!

[raft/aux] Add aux Raftstore - #1528

[raft/aux] Add aux Raftstore#1528
MariemBaccari wants to merge 2 commits into
interuss:masterfrom
Orbitalize:add_aux

MariemBaccari commented Jun 15, 2026 •

edited

Loading

Uh oh!

Uh oh!

the-glu left a comment

Uh oh!

mickmis left a comment

Uh oh!

mickmis Aug 17, 2026

Uh oh!

mickmis Aug 17, 2026

Uh oh!

mickmis Aug 17, 2026

Uh oh!

mickmis Aug 17, 2026

Uh oh!

the-glu Aug 18, 2026

Uh oh!

mickmis Aug 17, 2026

Uh oh!

mickmis Aug 17, 2026

Uh oh!

the-glu Aug 18, 2026

Uh oh!

mickmis Aug 17, 2026

Uh oh!

mickmis Aug 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		if _, ok := result.([]*auxmodels.DSSMetadata); !ok {
		return nil, stacktrace.NewError("unexpected result type: %T", result)

Uh oh!

Conversation

MariemBaccari commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

the-glu left a comment

Choose a reason for hiding this comment

Uh oh!

mickmis left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MariemBaccari commented Jun 15, 2026 •

edited

Loading