[raft/config] Support config changes#1572
Draft
MariemBaccari wants to merge 21 commits into
Draft
Conversation
the-glu
reviewed
Jun 29, 2026
| return nil, stacktrace.NewError("node ID %d not found in peers map", connectParams.NodeID) | ||
| } | ||
|
|
||
| // the persisted member list, takes precedence over --raft_peers. |
Member
There was a problem hiding this comment.
If it's overwritten, it should be inital_raft_peers (or bootstrap_) ?
| } | ||
|
|
||
| // loadMembers loads the persisted node ID -> peer URL table from dataDir/members.json, if it exists. | ||
| func loadMembers(dataDir string) (map[uint64]string, error) { |
Member
There was a problem hiding this comment.
File format should be versionned, so we can detect changes in the future
| flag.Uint64Var(&connectParameters.NodeID, "raft_node_id", 0, "Raft node ID for this instance (must be non-zero and unique within the cluster).") | ||
| flag.Uint64Var(&connectParameters.ClusterID, "raft_cluster_id", 1, "ID of the cluster, used to isolate different Raft clusters running in the same network (must be the same for all nodes in the cluster).") | ||
| flag.StringVar(&connectParameters.DataDir, "raft_datadir", defaultDataDir, "Directory for raft data (WAL segments and snapshots), required for restarts. These should not be deleted while the node is running or across restarts unless the node is being permanently shut down.") | ||
| flag.BoolVar(&connectParameters.Join, "raft_join", false, "Set on a node's first start when it is joining an already-running cluster (added via raftctl) rather than participating in the cluster's initial bootstrap.") |
Member
There was a problem hiding this comment.
No way to detect that automatically? That going to complexity a lot join operations
barroco
added
the
dss-raft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.