Fix Build Warnings#1826
Merged
Merged
Conversation
UMR1352
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Hotfixes an issue with the time crate, see https://github.com/time-rs/time/issues, issue 783. Better solution in the long run would be to wait for a fix from the time crate and apply this to our project, but the workaround should fix the CI for now.* Update: Reverted that change, as
time0.34.6 would have vulnerability RUSTSEC-2026-0009, and new version oftimewas released, addressing that issue.Also, the
use macroswas shadowing a re-export frompub use product_common::bindings::macros;, which ended up as an error in local clippy test run with CI setting, so renamed this as well.Type of change
Add an
xto the boxes that are relevant to your changes.BugWarning fix (a non-breaking change which fixesan issuea warning (with build))How the change has been tested
Checked locally if the build runs again.
Change checklist