Skip to content

Fix Build Warnings#1826

Merged
wulfraem merged 3 commits into
mainfrom
chore/fix-ci-errors
Jun 30, 2026
Merged

Fix Build Warnings#1826
wulfraem merged 3 commits into
mainfrom
chore/fix-ci-errors

Conversation

@wulfraem

@wulfraem wulfraem commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Description of change

Hotfixes an issue with the time crate, see https://github.com/time-rs/time/issues, issue 783. Better solution in the long run would be to wait for a fix from the time crate and apply this to our project, but the workaround should fix the CI for now.

* Update: Reverted that change, as time 0.34.6 would have vulnerability RUSTSEC-2026-0009, and new version of time was released, addressing that issue.

Also, the use macros was shadowing a re-export from pub use product_common::bindings::macros;, which ended up as an error in local clippy test run with CI setting, so renamed this as well.

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug Warning fix (a non-breaking change which fixes an issue a warning (with build))

How the change has been tested

Checked locally if the build runs again.

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code

@wulfraem wulfraem added Bug Something isn't working. Chore Tedious, typically non-functional change No changelog Excludes PR from becoming part of any changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Jun 12, 2026
@wulfraem wulfraem changed the title Fix CI Errors Fix Build Warnings Jun 15, 2026
@wulfraem wulfraem requested a review from UMR1352 June 24, 2026 08:56
@wulfraem wulfraem merged commit 858b914 into main Jun 30, 2026
12 checks passed
@UMR1352 UMR1352 deleted the chore/fix-ci-errors branch June 30, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working. Chore Tedious, typically non-functional change No changelog Excludes PR from becoming part of any changelog Rust Related to the core Rust code. Becomes part of the Rust changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants