Add volumetric clouds based on clayjohn example#8
Open
TheRealKaamy wants to merge 10 commits into
Open
Conversation
+ blend into universal sky on univsky_standard_sky.gdshader if enabled
referencing freed Texture2DRD objects - Disabling stops updates and releases the compute textures - Removing the resource clears its shader texture bindings before freeing them. - now dynamic Clouds works normally when the volumetric resource is null
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to use this addon in a little game project of mine but noticed volumetric clouds had not been implemented yet (#4). so I figured I'd give it a shot.
it's mostly Copypasta from the original Clay John's example.
universal sky glue code is mostly in
univsky_volumetric_clouds.gdshaderincwhich samples the clouds texture andunivsky_standard_sky.gdshaderblends the result into the sky.I also added a
VolumetricCloudsresource and an example scene to play around withI updated the readme, added more screenshots.
there's still some work to be done. the same intensity doesn't look good at every time of day. around
4.0looks great at night like in the screenshot (in my biased opinion), but looks pretty bad aroundd sunrise and sunset. for now it needs to be adjusted dynamically based on the time of day to get the best looking results.for now though, it does what I need for my game. I might add more features to the addon as development continues. and if i do, I'll send another PR.