Skip to content

registry: add imagemagick (aqua:ImageMagick/ImageMagick)#10118

Open
thernstig wants to merge 5 commits into
jdx:mainfrom
thernstig:feat/imagemagick
Open

registry: add imagemagick (aqua:ImageMagick/ImageMagick)#10118
thernstig wants to merge 5 commits into
jdx:mainfrom
thernstig:feat/imagemagick

Conversation

@thernstig
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the ImageMagick registry configuration by replacing the existing conda and asdf backends with aqua, and enabling the test command. The reviewer recommends retaining the original conda and asdf backends alongside the new aqua backend to prevent regressions for existing users.

Comment thread registry/imagemagick.toml Outdated
@thernstig thernstig changed the title registry: add tool-name (aqua:ImageMagick/ImageMagick) registry: add imagemagick (aqua:ImageMagick/ImageMagick) May 28, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 28, 2026

Greptile Summary

This PR adds aqua:ImageMagick/ImageMagick as the preferred (first-listed) backend for the ImageMagick registry entry, alongside the existing conda and asdf backends. It also promotes the previously commented-out test to an active one.

  • Adds aqua:ImageMagick/ImageMagick at the top of the backends list, matching the upstream GitHub repository (ImageMagick/ImageMagick).
  • Activates the version test using magick -version (single-dash, conventional for ImageMagick 7+) with expected = "ImageMagick {{version}}", which correctly matches the substring in the tool's version output.

Confidence Score: 5/5

A one-line registry addition with a well-formed backend reference and an activated version test — straightforward and low-risk.

The change is minimal: a new aqua backend pointing to the canonical ImageMagick/ImageMagick GitHub repository, placed first in the backend list per convention, and a test whose command and expected substring match standard ImageMagick 7+ output. No logic changes, no new code paths.

No files require special attention.

Important Files Changed

Filename Overview
registry/imagemagick.toml Adds aqua:ImageMagick/ImageMagick as the preferred backend and activates the previously commented-out version test with the correct command and expected output format.

Reviews (5): Last reviewed commit: "Revert tag in metadata.json to v4.517.0 ..." | Re-trigger Greptile

@thernstig
Copy link
Copy Markdown
Contributor Author

thernstig commented May 28, 2026

I am not able to run mise run format locally, it errors out on things, so I would guess some things are setup manually that I am unaware about. I am running in a plain Ubuntu machine.

edit: wrote an issue here about this #10121

Regarding the other failure imagemagick has not been released yet: https://github.com/aquaproj/aqua-registry/releases

@thernstig
Copy link
Copy Markdown
Contributor Author

It was released here: https://github.com/aquaproj/aqua-registry/releases/tag/v4.518.0. Not sure why it says it is not in the registry.

@thernstig
Copy link
Copy Markdown
Contributor Author

@risu729 help me here.

@risu729
Copy link
Copy Markdown
Contributor

risu729 commented May 29, 2026

@thernstig
Copy link
Copy Markdown
Contributor Author

@risu729 updating it manually did not make this repo happy. I thought that was what you indicated I should do.

@risu729
Copy link
Copy Markdown
Contributor

risu729 commented May 29, 2026

@thernstig You need to wait until the next mise release.

@jdx
Copy link
Copy Markdown
Owner

jdx commented May 29, 2026

@thernstig
Copy link
Copy Markdown
Contributor Author

I am checking this, as I thought they meant to support everything but Windows on Arm.

Or will mise not even allow this in even in that case, if everything is supported but WIndows on Arm 64?

@risu729
Copy link
Copy Markdown
Contributor

risu729 commented May 29, 2026

That's the opposite. Check aqua docs

@thernstig
Copy link
Copy Markdown
Contributor Author

@risu729 I saw that, but I thought their intention was to support everything but windows/amd64, but it seems only windows/amd64 is supported.

I have asked here if the rest of the support will be added, so we can keep this on hold, see aquaproj/aqua-registry#50281. They now added support in https://github.com/aquaproj/aqua-registry/pull/54605/changes.

My question is: Is this support now enough to make it into mise? Or what is required for it to be allowed to be added here? Is the support now enough?

@risu729
Copy link
Copy Markdown
Contributor

risu729 commented May 30, 2026

mise registry supports os/arch pairs. I think you can use it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants