Skip to content

Fix selfhosted Helm secret key collisions that broke GitLab PAT auth #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshw123 merged 3 commits into from
Jun 15, 2026
Merged

Fix selfhosted Helm secret key collisions that broke GitLab PAT auth #431

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0bba0a
Initial plan
Copilot May 9, 2026
03b857f
Fix selfhosted secret key mapping for ca_path and insecure
Copilot May 9, 2026
80f73bc
Merge branch 'main' into copilot/fix-gitlab-pat-issues
joshw123 Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions deploy/charts/version-checker/templates/secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,10 @@ data:
selfhosted.{{ $element.name }}.token: {{ $element.token | b64enc }}
{{- end }}
{{- if and (hasKey $element "insecure") $element.insecure }}
selfhosted.{{ $element.name }}.token: {{ $element.insecure | b64enc }}
selfhosted.{{ $element.name }}.insecure: {{ $element.insecure | b64enc }}
{{- end }}
{{- if and (hasKey $element "ca_path") $element.ca_path }}
selfhosted.{{ $element.name }}.token: {{ $element.ca_path | b64enc }}
selfhosted.{{ $element.name }}.ca_path: {{ $element.ca_path | b64enc }}
{{- end }}
{{- end }}

Expand Down
21 changes: 21 additions & 0 deletions deploy/charts/version-checker/tests/secret_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,3 +126,24 @@ tests:
value: dXNlcjI=
- notExists:
path: data["selfhosted.selfhosted2.password"]

- it: SelfHosted with token, insecure and ca_path
set:
selfhosted:
- name: gitlab
host: gitlab.example.com
token: glpat-test
insecure: "true"
ca_path: /mnt/ca.pem
asserts:
- hasDocuments:
count: 1
- equal:
path: data["selfhosted.gitlab.token"]
value: Z2xwYXQtdGVzdA==
- equal:
path: data["selfhosted.gitlab.insecure"]
value: dHJ1ZQ==
- equal:
path: data["selfhosted.gitlab.ca_path"]
value: L21udC9jYS5wZW0=
Loading