Allowing for CCE and HIP compilers for interoperability#62
Conversation
|
Hi, thanks for the change, we don't have a super active maintainer right now for this. Anyway: if you wanted to check for Kokkos Version we could get rid of the ifdefs altogether and just Kokkos::SharedSpace, but its only available in Kokkos 4.0. In Kokkos 4.0 HIP is also not experimental there (for backward compatibility we do have aliases in the Experimental namespace for now). Thoughts? |
|
@crtrott thanks for the feedback. I believe this is a change we made on our side working from kokkos develop before the full 4.0 was available. So there might be a better way to handle this using Kokkos::SharedSpace. We'll look into it. |
|
Again it depends. If you are still stuck on Kokkos 3.7 I think this is fine (and it will work with 4.0 and likely 4.1). But if you are anyway keeping up-to-date and we don't need 3.7 support we can update this to use SharedSpace. |
|
Right now we're using 4.0 on RZVernal and 3.7 on the other platforms we support. We'll move to all 4.0 in the future but still working on the timeline for that. |
In the process for using CCE 15.0.1 and Rocm 5.4.3, it was necessary to shield new ifdef variables.