Skip to content

Allowing for CCE and HIP compilers for interoperability#62

Open
srinathv wants to merge 2 commits into
kokkos:developfrom
srinathv:develop
Open

Allowing for CCE and HIP compilers for interoperability#62
srinathv wants to merge 2 commits into
kokkos:developfrom
srinathv:develop

Conversation

@srinathv
Copy link
Copy Markdown

In the process for using CCE 15.0.1 and Rocm 5.4.3, it was necessary to shield new ifdef variables.

@crtrott
Copy link
Copy Markdown
Member

crtrott commented Apr 20, 2023

Hi,

thanks for the change, we don't have a super active maintainer right now for this. Anyway: if you wanted to check for Kokkos Version we could get rid of the ifdefs altogether and just Kokkos::SharedSpace, but its only available in Kokkos 4.0. In Kokkos 4.0 HIP is also not experimental there (for backward compatibility we do have aliases in the Experimental namespace for now). Thoughts?

@cferenba
Copy link
Copy Markdown

@crtrott thanks for the feedback. I believe this is a change we made on our side working from kokkos develop before the full 4.0 was available. So there might be a better way to handle this using Kokkos::SharedSpace. We'll look into it.

@crtrott
Copy link
Copy Markdown
Member

crtrott commented Apr 20, 2023

Again it depends. If you are still stuck on Kokkos 3.7 I think this is fine (and it will work with 4.0 and likely 4.1). But if you are anyway keeping up-to-date and we don't need 3.7 support we can update this to use SharedSpace.

@cferenba
Copy link
Copy Markdown

Right now we're using 4.0 on RZVernal and 3.7 on the other platforms we support. We'll move to all 4.0 in the future but still working on the timeline for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants