Skip to content

Improve kokkos_print_configuration#80

Open
pzehner wants to merge 2 commits into
kokkos:developfrom
pzehner:feature/optional-print-config-argument
Open

Improve kokkos_print_configuration#80
pzehner wants to merge 2 commits into
kokkos:developfrom
pzehner:feature/optional-print-config-argument

Conversation

@pzehner
Copy link
Copy Markdown
Contributor

@pzehner pzehner commented Jun 24, 2025

This PR improves the kokkos_print_subroutine by making the file name argument optional. If no arguments are provided, the subroutine requests Kokkos::print_configuration to write in output_unit.

Copy link
Copy Markdown

@JBludau JBludau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change all the tests?

@pzehner
Copy link
Copy Markdown
Contributor Author

pzehner commented Jun 25, 2025

Because I can? I had to pick one, so I picked them all.

Copy link
Copy Markdown

@JBludau JBludau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@pzehner
Copy link
Copy Markdown
Contributor Author

pzehner commented Jun 25, 2025

I can enable it for some tests, to decrease the diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants