runtime: improvement/test struct for api mode watcher#2022
Open
daemonfire300 wants to merge 9 commits into
Open
runtime: improvement/test struct for api mode watcher#2022daemonfire300 wants to merge 9 commits into
daemonfire300 wants to merge 9 commits into
Conversation
2c81908 to
ea52878
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2022 +/- ##
=======================================
+ Coverage 77.3% 77.4% +0.1%
=======================================
Files 89 89
Lines 9016 9102 +86
=======================================
+ Hits 6967 7038 +71
- Misses 2049 2064 +15
🚀 New features to boost your workflow:
|
Author
|
cc @mateiidavid since you have been on the old PR. |
Author
|
I ll try to do a proper fix of the clippy issues tomorrow. Caught me by surprise because afaik |
e9269b5 to
e932559
Compare
Member
|
Don't worry about the cc) @clux should we consider CARGO_RESOLVER_INCOMPATIBLE_RUST_VERSIONS ? |
Signed-off-by: Julius Foitzik <info@accountr.eu>
Issue: kube-rs#1528 Signed-off-by: Julius Foitzik <info@accountr.eu>
Signed-off-by: Julius Foitzik <info@accountr.eu>
Signed-off-by: Julius Foitzik <info@accountr.eu>
Signed-off-by: Julius Foitzik <info@accountr.eu>
Signed-off-by: Julius Foitzik <info@accountr.eu>
e932559 to
b14d9f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Motivation is #1528
Instead of reviving the stale PR I attempted a new approach from scratch.
Solution
IMPORTANT NOTE: Contains unrelated files that are currently tracked in git because they have to be otherwise my devShell does not work (flake, nix, direnv). So feel free to ignore the flake.nix+flake.lock, if you want me to and like the nix devShell I can put that on a dedicated second PR. Also added a helper and git hooks for myself to have a Cargo.lock on hand, because I prefer having one when developing within a nix devShell, makes it more reproducible. I.e., I am going to remove those files from the PR later.
It's not much and the change is NOT complete, before continuing I wanted to discuss the "interface" and behaviour of test struct(s). For example does the Duration i.e., ability to sleep/wait between calls to watch make sense, are we missing something to model a certain test. (Also I am not 100% sure whether the location of where I put the tests is the desired location for using that test struct.)
Happy to receive feedback.