refactor(labextension): replace Kale toolbar polling with reactive state handling#681
refactor(labextension): replace Kale toolbar polling with reactive state handling#681Sayan4496 wants to merge 15 commits into
Conversation
…mands integrated with Kale deployment flow Signed-off-by: Sayan Deyashi <deyashisayan2@gmail.com>
…eployType typing Signed-off-by: Sayan Deyashi <deyashisayan2@gmail.com>
Signed-off-by: Sayan Deyashi <deyashisayan2@gmail.com>
Signed-off-by: Sayan Deyashi <deyashisayan2@gmail.com>
Signed-off-by: Sayan Deyashi <deyashisayan2@gmail.com>
Signed-off-by: Sayan Deyashi <deyashisayan2@gmail.com>
…ate handling Signed-off-by: Sayan Deyashi <deyashisayan2@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @jesuino, Thanks! |
|
Hello @Sayan4496 Sorry for the delay, we were focusing on other tasks and could not find time to check this until today. Would you please solve the conflicts so I can test it locally? Thanks! |
Signed-off-by: Sayan Deyashi <deyashisayan2@gmail.com>
Signed-off-by: Sayan Deyashi <deyashisayan2@gmail.com>
Signed-off-by: Sayan Deyashi <deyashisayan2@gmail.com>
Signed-off-by: Sayan Deyashi <deyashisayan2@gmail.com>
Signed-off-by: Sayan Deyashi <deyashisayan2@gmail.com>
Signed-off-by: Sayan Deyashi <deyashisayan2@gmail.com>
Signed-off-by: Sayan Deyashi <deyashisayan2@gmail.com>
3297c32 to
93cb66b
Compare
|
Thanks for the review and patience, @jesuino! I resolved the conflicts, updated the reactive toolbar state handling implementation, and fixed the CI/lint issues. All checks are passing now. Please let me know if any further changes are needed. |
Summary
This PR replaces the polling mechanism previously used to detect the Kale enable state in the JupyterLab toolbar.
Previously the toolbar relied on a
setIntervalloop to repeatedly check whether Kale was enabled. This approach introduced unnecessary polling in a React-based UI.This change introduces a reactive callback mechanism that notifies the toolbar whenever the Kale state changes.
Changes
setIntervalpolling fromkaleToolbar.tsonKaleStateChangecallback inKubeflowKaleLeftPanelBenefits
Testing
Closes #649