fix: use previous release tag for benchmark comparison instead of release branch#2957
fix: use previous release tag for benchmark comparison instead of release branch#2957bhope wants to merge 2 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bhope The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
This issue is currently awaiting triage. If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The
ci-benchmark-tests-releasebranchjob compares benchmarks against release branch by fetching it from upstream. This requires the release branch to exist on the upstream repo before the release PR can merge.The CI job to always fail on release PRs. Example https://github.com/kubernetes/kube-state-metrics/actions/runs/25844106890/job/75935367272?pr=2949
Fix by switching to compare prior tags instead. Tags always exist on upstream, so this works in all cases.