Skip to content

fix: use previous release tag for benchmark comparison instead of release branch#2957

Open
bhope wants to merge 2 commits into
kubernetes:mainfrom
bhope:fix-ci-benchmarks-release
Open

fix: use previous release tag for benchmark comparison instead of release branch#2957
bhope wants to merge 2 commits into
kubernetes:mainfrom
bhope:fix-ci-benchmarks-release

Conversation

@bhope
Copy link
Copy Markdown
Member

@bhope bhope commented May 14, 2026

The ci-benchmark-tests-releasebranch job compares benchmarks against release branch by fetching it from upstream. This requires the release branch to exist on the upstream repo before the release PR can merge.

The CI job to always fail on release PRs. Example https://github.com/kubernetes/kube-state-metrics/actions/runs/25844106890/job/75935367272?pr=2949

Fix by switching to compare prior tags instead. Tags always exist on upstream, so this works in all cases.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bhope
Once this PR has been reviewed and has the lgtm label, please assign mrueg for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 14, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

This issue is currently awaiting triage.

If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-project-automation github-project-automation Bot moved this to Needs Triage in SIG Instrumentation May 14, 2026
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 14, 2026
@bhope
Copy link
Copy Markdown
Member Author

bhope commented May 14, 2026

cc @rexagod @mrueg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

2 participants