fix: Wildcard label/annotation clobbering#2960
Conversation
k8s-ci-robot
added
the
needs-triage
|
This issue is currently awaiting triage. If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ringerc The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/L
Wildcard entries in labels_allow_list and annotations_allow_list clobbered resource-specific entries. So it was not possible to express the configuration "label A for all resource types, and additionally label B for this specific resource type". Fix by merging the wildcard and resource-specific discovered labels. Fixes kubernetes#2488
ringerc
force-pushed
the
fix-allowlist-wildcard-clobber
branch
from
984fa34 to
afe5397
Compare
2 participants
Wildcard entries in
labels_allow_listandannotations_allow_listclobbered resource-specific entries per #2488. So it was not possible to express the configuration "label A for all resource types, and additionally label B for this specific resource type".Fix by merging the wildcard and resource-specific discovered labels.
No effect on cardinality except possibly if an existing configuration has masked config due to this bug; if any annotations (or labels, where on mutable resources) have high rates of churn on underlying resources, the newly-unclobbered labels might increase cardinality. This is really a user misconfiguration, but was previously masked by this bug.
Fixes #2488