fix(#11051): log getUserSettings errors instead of silently swallowing them#11065
Open
shivv23 wants to merge 1 commit into
Open
fix(#11051): log getUserSettings errors instead of silently swallowing them#11065shivv23 wants to merge 1 commit into
shivv23 wants to merge 1 commit into
Conversation
…lowing them The internal getUserSettings helper in authorization.js catches errors with .catch(err => err), silently dropping the error with no log line. This makes getUserSettings failures invisible in production, leaving operators unable to diagnose issues like CouchDB connectivity problems or malformed user-settings docs. Added logger.error() call in the .catch handler, following the same pattern used by captureReplicationFailures in the same file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
getUserSettingshelper in the authorization middleware silently swallows errors by catching them and returning the error object without any logging. This makes failures invisible in production, leaving operators unable to diagnose issues such as CouchDB connectivity problems or malformed user-settings documents.Changes
logger.error()call in the.catchhandler ofgetUserSettings, following the same pattern used bycaptureReplicationFailuresin the same file.Testing
getUserCtxfailure andgetUserSettingsfailure scenarios produce log output.