fix(#9381): accept_case_reports transition fails to persist doc changes#11066
Open
shivv23 wants to merge 1 commit into
Open
fix(#9381): accept_case_reports transition fails to persist doc changes#11066shivv23 wants to merge 1 commit into
shivv23 wants to merge 1 commit into
Conversation
…changes The onMatch function returns silenceRegistrations() which resolves to undefined. The transitions framework treats falsy return values as 'no changes', so doc modifications (messages, place_uuid) are never persisted to the database. Fixed by appending .then(() => true) to ensure a truthy return value when the transition completes successfully, matching the pattern used by accept_patient_reports and registration transitions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
accept_case_reportstransition'sonMatchfunction returns the result ofsilenceRegistrations(), which resolves toundefined. The transitions framework treats falsy return values as "no changes," so document modifications (messages,place_uuid) are never persisted to the database.Changes
.then(() => true)to thesilenceRegistrationscall to ensure a truthy return value when the transition completes successfully.Testing
accept_case_reportstransition unit tests pass.accept_patient_reportsandregistrationtransitions, which already returntrueon success.