Skip to content

fix(#10241): prevent race condition in unique() validation allowing duplicates #11069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shivv23 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(#10241): prevent race condition in unique() validation allowing duplicates #11069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 26 additions & 14 deletions shared-libs/validation/src/validation_utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ const { Qualifier, Report } = require('@medic/cht-datasource');
let db;
let dataContext;

const inFlightLocks = new Set();

const lowerCaseString = obj => typeof obj === 'string' ? obj.toLowerCase() : obj;

const executeExistsRequest = async (freetext) => {
Expand Down Expand Up @@ -71,23 +73,33 @@ const exists = async (doc, fields, options = {}) => {
}
const requestOptions = getExistsRequestOptions(fields, doc);
addAdditionalFilters(options, requestOptions);
const responses = await getExistsResponses(requestOptions);

const ids = getIntersection(responses).filter(id => id !== doc._id);
if (!ids.length) {
return false;
const lockKey = [...requestOptions].sort((a, b) => a.localeCompare(b)).join('::').toLowerCase();
if (inFlightLocks.has(lockKey)) {
return true;
}
inFlightLocks.add(lockKey);

const result = await db.medic.allDocs({ keys: ids, include_docs: true });
const startDate = parseStartDate(options.duration);
// filter out docs with errors
return result.rows.some(row => {
const doc = row.doc;
return (
(!doc.errors || doc.errors.length === 0) &&
(!startDate || doc.reported_date >= startDate)
);
});
try {
const responses = await getExistsResponses(requestOptions);

const ids = getIntersection(responses).filter(id => id !== doc._id);
if (!ids.length) {
return false;
}

const result = await db.medic.allDocs({ keys: ids, include_docs: true });
const startDate = parseStartDate(options.duration);
return result.rows.some(row => {
const rowDoc = row.doc;
return (
(!rowDoc.errors || rowDoc.errors.length === 0) &&
(!startDate || rowDoc.reported_date >= startDate)
);
});
} finally {
inFlightLocks.delete(lockKey);
}
};

const compareDateAfter = (testDate, reportedDate, duration) => {
Expand Down