improvement: add es/fr/ne/sw translations to default and demo configs

config/default/translations/messages-en.properties

@@ -17,7 +17,6 @@ clinic.field.parent = Area
 contact = Contact
 contact.phone = Phone
 contact.notes = Notes
-contact.parent = Belongs to
 contact.parent.external_id = Household external ID
 contact.parent.name = Household name
 contact.parent.parent.contact.name = CHV Name

config/demo/translations/messages-en.properties

@@ -17,7 +17,6 @@ clinic.field.parent = Area
 contact = Contact
 contact.phone = Phone
 contact.notes = Notes
-contact.parent = Belongs to
 contact.parent.external_id = Household external ID
 contact.parent.name = Household name
 contact.parent.parent.contact.name = CHV Name

scripts/ci/lint-translations.js

@@ -1,14 +1,25 @@
 const { checkTranslations, TranslationException } = require('@medic/translation-checker');
 
 const SUPPORTED_LANGUAGES = [ 'en', 'es', 'fr', 'ne', 'sw' ];
-const TRANSLATION_DIR = `${__dirname}/../../api/resources/translations`;
-const TRANSLATION_OPTIONS = {
+const API_TRANSLATION_DIR = `${__dirname}/../../api/resources/translations`;
+const CONFIG_TRANSLATION_DIRS = [
+  `${__dirname}/../../config/default/translations`,
+  `${__dirname}/../../config/demo/translations`,
+];
+const API_OPTIONS = {
   checkPlaceholders: true,
   checkEmpties: true,
   checkMessageformat: true,
   checkMissing: true,
   languages: SUPPORTED_LANGUAGES
 };
+const CONFIG_OPTIONS = {
+  checkPlaceholders: true,
+  checkEmpties: false,
+  checkMessageformat: true,
+  checkMissing: true,
+  languages: SUPPORTED_LANGUAGES
+};
 
 const handleError = (e) => {
   if (e instanceof TranslationException && !!e.errors) {
@@ -22,14 +33,30 @@ const handleError = (e) => {
 };
 
 const run = async () => {
+  let failed = false;
+
   try {
-    const files = await checkTranslations(TRANSLATION_DIR, TRANSLATION_OPTIONS);
-    console.log(`Files checked: ${files}`);
-    console.log('Linting translation files passed');
+    const files = await checkTranslations(API_TRANSLATION_DIR, API_OPTIONS);
+    console.log(`API files checked: ${files}`);
   } catch (e) {
-    const exitCode = handleError(e);
-    process.exit(exitCode);
+    handleError(e);
+    failed = true;
+  }
+
+  for (const dir of CONFIG_TRANSLATION_DIRS) {
+    try {
+      const files = await checkTranslations(dir, CONFIG_OPTIONS);
+      console.log(`Config files checked (${dir.split('/').slice(-3, -1).join('/')}): ${files}`);
+    } catch (e) {
+      handleError(e);
+      failed = true;
+    }
+  }
+
+  if (failed) {
+    process.exit(1);
   }
+  console.log('Linting translation files passed');
 };
 
 console.log('Linting translation files...');