feat(#10662): display contact profile photo#11087
Open
benkags wants to merge 1 commit into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
benkags
changed the title
benkags
force-pushed
the
10662-display-profile-photo
branch
3 times, most recently
from
3fc31cf to
9395085
Compare
- add ContactPhotoComponent - replace the resource-icon span in contacts-content with mm-contact-photo - expose photo_field on contact-type config - use photo as default photoField
benkags
force-pushed
the
10662-display-profile-photo
branch
from
9395085 to
63b4b83
Compare
Contributor
Author
|
Hi @dianabarsan @jkuester I decoupled this from #10923 since profile photo display automatically work as long as the photo has been attached to the contact doc; so this can be reviewed as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the ability to display the profile photo of the user when provided in the contact profile. The profile photo field is configurable in contact type definition.
Code review checklist
can_view_old_navigationpermission to see the old design. Test it has appropriate design for RTL languages.License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.