Skip to content

feat(#10973): adding byPhone qualifier #11101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
witash wants to merge 3 commits into
base: master
Choose a base branch
from
+1,196 −395

fix(#10973): changing how batch requests work

9630746
Select commit
Loading
Failed to load commit list.
Draft

feat(#10973): adding byPhone qualifier #11101

fix(#10973): changing how batch requests work
9630746
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed May 25, 2026 in 1m 53s

Quality Gate failed

Failed conditions
8 New issues

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 40 in webapp/src/ts/services/integration-api.service.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Member 'chtDatasourceService:CHTDatasourceService' is never reassigned; mark it as `readonly`. 

See more on https://sonarcloud.io/project/issues?id=medic_cht-core&issues=AZ5LcYop68hX41I6qCxV&open=AZ5LcYop68hX41I6qCxV&pullRequest=11101

Check warning on line 236 in api/src/controllers/contact.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=medic_cht-core&issues=AZ5eegymVJBT9wqP8JR1&open=AZ5eegymVJBT9wqP8JR1&pullRequest=11101

Check failure on line 128 in api/src/controllers/contact.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 6 to the 5 allowed. 

See more on https://sonarcloud.io/project/issues?id=medic_cht-core&issues=AZ5LcYuH68hX41I6qCxY&open=AZ5LcYuH68hX41I6qCxY&pullRequest=11101

Check warning on line 33 in shared-libs/transitions/src/transitions/update_sent_by.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=medic_cht-core&issues=AZ5LcYtV68hX41I6qCxX&open=AZ5LcYtV68hX41I6qCxX&pullRequest=11101

Check warning on line 235 in api/src/controllers/contact.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

`COMBINABLE` should be a `Set`, and use `COMBINABLE.has()` to check existence or non-existence. 

See more on https://sonarcloud.io/project/issues?id=medic_cht-core&issues=AZ5eegymVJBT9wqP8JR0&open=AZ5eegymVJBT9wqP8JR0&pullRequest=11101

Check failure on line 39 in shared-libs/cht-datasource/src/remote/contact.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 7 to the 5 allowed. 

See more on https://sonarcloud.io/project/issues?id=medic_cht-core&issues=AZ5eegt9VJBT9wqP8JRz&open=AZ5eegt9VJBT9wqP8JRz&pullRequest=11101

Check warning on line 19 in webapp/src/js/enketo/widgets/phone-widget.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=medic_cht-core&issues=AZ5LcYsR68hX41I6qCxW&open=AZ5LcYsR68hX41I6qCxW&pullRequest=11101

Check warning on line 245 in api/src/controllers/contact.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Review this usage of "COMBINABLE" as it can only be empty here. 

See more on https://sonarcloud.io/project/issues?id=medic_cht-core&issues=AZ5eegymVJBT9wqP8JR2&open=AZ5eegymVJBT9wqP8JR2&pullRequest=11101
View more details on SonarQubeCloud