fix(tests): fix 48 native-hooks test failures in docker CI#1610
Merged
Conversation
- crewai_hooks: reload adapter module after installing crewai.hooks stubs to reset _HOOKS_AVAILABLE flag (38 tests) - semantic_kernel_hooks: replace deprecated asyncio.get_event_loop() with asyncio.run() for Python 3.11+ compat (8 tests) - smolagents_hooks: fix test that used blocked pattern in non-failing assertion step (1 test) - adapter_exception_identity: remove xfail from openai_agents_sdk now that native hooks conversion is complete (1 test) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🤖 AI Agent: security-scanner — View detailsNo security issues found. |
🤖 AI Agent: breaking-change-detector — API CompatibilityAPI CompatibilityNo breaking changes detected. |
🤖 AI Agent: test-generator — `agent-governance-python/agent-os/tests/test_crewai_hooks.py`
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
🤖 AI Agent: docs-sync-checker — Docs SyncDocs Sync
|
🤖 AI Agent: code-reviewer — Action Items:TL;DR: 0 blockers, 1 warning. Fixes test failures effectively but introduces a potential issue with module reloading.
Action Items:
Warnings:
|
PR Review Summary
Verdict: ❌ Changes needed |
imran-siddique
added a commit
to imran-siddique/agent-governance-toolkit
that referenced
this pull request
May 4, 2026
…#1610) - crewai_hooks: reload adapter module after installing crewai.hooks stubs to reset _HOOKS_AVAILABLE flag (38 tests) - semantic_kernel_hooks: replace deprecated asyncio.get_event_loop() with asyncio.run() for Python 3.11+ compat (8 tests) - smolagents_hooks: fix test that used blocked pattern in non-failing assertion step (1 test) - adapter_exception_identity: remove xfail from openai_agents_sdk now that native hooks conversion is complete (1 test) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
MohammadHaroonAbuomar
pushed a commit
to MohammadHaroonAbuomar/agt-acs
that referenced
this pull request
Jun 1, 2026
…#1610) - crewai_hooks: reload adapter module after installing crewai.hooks stubs to reset _HOOKS_AVAILABLE flag (38 tests) - semantic_kernel_hooks: replace deprecated asyncio.get_event_loop() with asyncio.run() for Python 3.11+ compat (8 tests) - smolagents_hooks: fix test that used blocked pattern in non-failing assertion step (1 test) - adapter_exception_identity: remove xfail from openai_agents_sdk now that native hooks conversion is complete (1 test) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes all 48 test failures introduced by the native-hooks PRs (#1582, #1585, #1588, #1591, #1605):