Add warning for nn.ModuleList usage with quantum gates - #320
Open
yurekami wants to merge 1 commit into
Open
Conversation
Added a UserWarning when nn.ModuleList or nn.ModuleDict is used instead of tq.QuantumModuleList or tq.QuantumModuleDict. This helps users understand why static mode and tq2qiskit conversion may fail. The warning is issued during static_on() when non-quantum container types are detected with quantum gate children. Fixes mit-han-lab#178 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added a
UserWarningwhennn.ModuleListornn.ModuleDictis used instead oftq.QuantumModuleListortq.QuantumModuleDictin quantum modules.Problem
When users use
nn.ModuleListto contain quantum gates,tq2qiskitconversion fails because:nn.ModuleListdoesn't havestatic_on()/static_off()methodsnn.ModuleListdoesn't have a.graphattribute for the flattening logicbuild_flat_module_list()can't handle regular containersSolution
Issue a warning during
static_on()to help users understand the issue and guide them to use the correct container types.Test plan
Fixes #178
🤖 Generated with Claude Code