Handle ParameterExpression in qiskit2tq conversion - #326
Open
yurekami wants to merge 1 commit into
Open
Conversation
Add support for converting Qiskit circuits with unbound parameters
(ParameterExpression) to TorchQuantum. Previously, attempting to
convert a circuit with symbolic parameters would fail with:
TypeError: ParameterExpression with unbound parameters cannot
be cast to a float.
Changes:
- Add _has_unbound_params() helper to detect unbound parameters
- Add _convert_params() helper to safely convert gate parameters
- Update qiskit2tq_op_history() to handle unbound parameters
- Update qiskit2tq_Operator() to handle unbound parameters
- Remove debug print statement from qiskit2tq_op_history()
When a circuit has unbound parameters, the converted TorchQuantum
layer will have trainable gates without initial parameter values,
allowing them to be trained during optimization.
Fixes mit-han-lab#198
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ParameterExpression) to TorchQuantumTypeError: ParameterExpression with unbound parameters cannot be cast to a float.Changes
_has_unbound_params()helper to detect unbound ParameterExpression objects_convert_params()helper to safely convert gate parametersqiskit2tq_op_history()to handle unbound parametersqiskit2tq_Operator()to handle unbound parametersqiskit2tq_op_history()Behavior
When a circuit has unbound parameters, the converted TorchQuantum layer will have trainable gates without initial parameter values (
init_params=None), allowing them to be trained during optimization.Example
Test plan
Fixes #198
🤖 Generated with Claude Code