fix(json): serialize BTreeMap keys with unit enum variants#906
Open
leno23 wants to merge 1 commit into
Open
Conversation
Map keys that deserialize as UnitVariant (e.g. BTreeMap<MyEnum, V>) are now stringified by variant name instead of panicking. Fixes mitsuhiko#689. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #689.
assert_json_snapshot!panicked when serializingBTreeMapkeys that are unit enum variants (e.g.BTreeMap<MyEnum, bool>). JSON map keys now supportUnitVariantnames in addition to strings and numeric keys.Test plan
cargo test -p insta --lib test_to_string_unit_variant_keyscargo test -p insta --test test_basic test_btreemap_enum_keys_json --features json