fix(redactions): apply sorted_redaction after other redactions#907
Open
leno23 wants to merge 1 commit into
Open
fix(redactions): apply sorted_redaction after other redactions#907leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
Sort redactions now run in a second pass so value replacements (e.g. `[].a => "[redacted]"`) are applied before sorting. Fixes mitsuhiko#683. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #683.
sorted_redaction()is now applied in a second pass after all other redactions, so snapshot output no longer depends on the order entries appear in the redaction map.Changes
Redaction::Sortvariant used bysorted_redaction()Redactions::apply_to_contentruns non-sort redactions first, then sort redactionsTest plan
cargo test -p insta --lib --features redactions,json sort_redaction_ordercargo test -p insta --test test_redaction --features redactions,json,yaml