add infopanel to show current LV2 path#5
Open
jardous wants to merge 1 commit into
Open
Conversation
falkTX
reviewed
Jan 30, 2023
| self.fProccessSDK.terminate() | ||
|
|
||
| def setInformation(self, info): | ||
| self.ui.label_information.setText(info) |
Member
There was a problem hiding this comment.
add an empty line after this and the code separator
falkTX
reviewed
Jan 30, 2023
|
|
||
| if os.getenv("LV2_PATH") is None: | ||
| lv2_path = os.getenv("LV2_PATH") | ||
| if lv2_path is None: |
Member
There was a problem hiding this comment.
lv2_path and LV2_PATH point to the same thing here, best to just use LV2_PATH as single var
falkTX
reviewed
Jan 30, 2023
| gui = PanelWindow() | ||
| gui.show() | ||
|
|
||
| gui.setInformation("<b>LV2 path:</b><br/>" + "<br/>".join(lv2_path.split(":"))) |
Member
There was a problem hiding this comment.
this call should be done before show.
better yet, pass it as argument to the class constructor.
falkTX
requested changes
Jan 30, 2023
Member
falkTX
left a comment
falkTX
left a comment
There was a problem hiding this comment.
added a few comments for things to tweak
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.