Skip to content

Tune footswitch image size#19

Open
vallsv wants to merge 1 commit into
mod-audio:masterfrom
vallsv:patch-4
Open

Tune footswitch image size#19
vallsv wants to merge 1 commit into
mod-audio:masterfrom
vallsv:patch-4

Conversation

@vallsv
Copy link
Copy Markdown
Contributor

@vallsv vallsv commented Dec 14, 2019

Hi,

I was working on trigger control and i saw a small glitch.

It looks like the footswitch sprite film to not have anymore the same orientation.

This PR only fix the display, but the animation looks to be not working. Maybe you still have to investigate something.

Here what it was displayed with modsdk master:
trigger glitch

On the the last Mod Device release installed on my device, i don't have the same sprite, nor the same code. And there was another glitch: when clicking on the button the sprite have a small gap, then i tune this same property this way: background-size:127px 64px;. I don't know which version is in the truth.

@vallsv
Copy link
Copy Markdown
Contributor Author

vallsv commented Dec 14, 2019

background-size:127px 64px; -> witch means maybe both sprites are not aligned.

Then, just to know, is modsdk is the base code, and you copy the html to mod-ui time to time? Or is it the reverse? Or it's just 2 different base code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant