FCL-1843 | add VCR with fixtures for isolated E2E test running#2892
Merged
Conversation
dragon-dxw
reviewed
Mar 18, 2026
dragon-dxw
reviewed
Mar 18, 2026
dragon-dxw
reviewed
Mar 18, 2026
dragon-dxw
approved these changes
Mar 18, 2026
Collaborator
|
I'm dubious about the maturity of the VCR framework given the amount of extra effort you had to put into it to make it do its job. |
3fae6de to
02da4fc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2892 +/- ##
=======================================
Coverage 95.65% 95.65%
=======================================
Files 97 97
Lines 3568 3568
Branches 145 145
=======================================
Hits 3413 3413
Misses 115 115
Partials 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
809ac87 to
86b394f
Compare
46fa39e to
0823643
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this PR:
This adds VCR to allow us to record and playback responses from external services. This means when we run E2E tests, we can test them against consistent responses in dev and CI.
Jira card / Rollbar error (etc)
https://national-archives.atlassian.net/browse/FCL-1843