Skip to content

FCL-1843 | add VCR with fixtures for isolated E2E test running#2892

Merged
jlhdxw merged 1 commit into
mainfrom
FCL-1843/isolate-e2e-tests-to-fixtures
Mar 20, 2026
Merged

FCL-1843 | add VCR with fixtures for isolated E2E test running#2892
jlhdxw merged 1 commit into
mainfrom
FCL-1843/isolate-e2e-tests-to-fixtures

Conversation

@jlhdxw
Copy link
Copy Markdown
Collaborator

@jlhdxw jlhdxw commented Mar 18, 2026

Changes in this PR:

This adds VCR to allow us to record and playback responses from external services. This means when we run E2E tests, we can test them against consistent responses in dev and CI.

Jira card / Rollbar error (etc)

https://national-archives.atlassian.net/browse/FCL-1843

Comment thread .env.example
Comment thread config/vcr_config.py
Comment thread config/vcr_config.py Outdated
@dragon-dxw
Copy link
Copy Markdown
Collaborator

I'm dubious about the maturity of the VCR framework given the amount of extra effort you had to put into it to make it do its job.

@jlhdxw jlhdxw force-pushed the FCL-1843/isolate-e2e-tests-to-fixtures branch from 3fae6de to 02da4fc Compare March 18, 2026 15:54
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.65%. Comparing base (74565c9) to head (0823643).
⚠️ Report is 26 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2892   +/-   ##
=======================================
  Coverage   95.65%   95.65%           
=======================================
  Files          97       97           
  Lines        3568     3568           
  Branches      145      145           
=======================================
  Hits         3413     3413           
  Misses        115      115           
  Partials       40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jlhdxw jlhdxw force-pushed the FCL-1843/isolate-e2e-tests-to-fixtures branch 5 times, most recently from 809ac87 to 86b394f Compare March 20, 2026 14:33
@jlhdxw jlhdxw force-pushed the FCL-1843/isolate-e2e-tests-to-fixtures branch from 46fa39e to 0823643 Compare March 20, 2026 16:26
@jlhdxw jlhdxw enabled auto-merge March 20, 2026 16:26
@jlhdxw jlhdxw added this pull request to the merge queue Mar 20, 2026
Merged via the queue into main with commit 61c9b95 Mar 20, 2026
21 checks passed
@jlhdxw jlhdxw deleted the FCL-1843/isolate-e2e-tests-to-fixtures branch March 20, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants