GAZ-301: Cleanup commandline usage and fix missing examples#144
Open
PranjaliBhardwaj wants to merge 1 commit into
Open
GAZ-301: Cleanup commandline usage and fix missing examples#144PranjaliBhardwaj wants to merge 1 commit into
PranjaliBhardwaj wants to merge 1 commit into
Conversation
Signed-off-by: Pranjali Bhardwaj <pranjalisharma6543@gmail.com>
Contributor
|
👋 Hi @PranjaliBhardwaj — thank you for your pull request. This PR is currently blocked because we do not have a Contributor License Agreement (CLA) on file for your GitHub account. To get unblocked:
|
tdaly-mifos
added
the
cla-required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed: #143
Fixed the missing Example 5 in the usage help (it was skipping from 4 to 6).
Added a specific example for infra-only deployment since I find myself doing that a lot during testing.
Actually implemented the -k and -v flags. They were already in the getopts optstring but weren't handled in the case block, so they were just throwing "Unknown option" errors. Now you can override k8s_version and GAZELLE_VERSION directly from the command line.
Cleaned up some trailing whitespace in the usage strings.
initially i thought adding flags for config value, but later decide to focus often toggled version without editing config.ini.