[PHEE-637] Batch Payment Mock API's#28
Merged
Merged
Conversation
fynmanoj
suggested changes
Mar 20, 2024
Contributor
fynmanoj
left a comment
fynmanoj
left a comment
There was a problem hiding this comment.
Requested clarification
| return batchService.getBatchSummary(batchId); | ||
| } | ||
|
|
||
| @GetMapping(value = "/batches/{batchId}/detail", produces = MediaType.APPLICATION_JSON_VALUE) |
Contributor
There was a problem hiding this comment.
This API documentation should be upated. Please attach link to postman PR.
Also make sure that the validations and error handling is done.
ref: https://docs.google.com/spreadsheets/d/13TdoMUXtmV4MqwafbZu4_zvwOUhbO2WTs1UxZOLXHXI/edit#gid=0
Contributor
Author
There was a problem hiding this comment.
openMF/ph-ee-env-template#411
I have added postman collection for this.
fynmanoj
suggested changes
Mar 20, 2024
|
|
||
| private Transfer getSingleTransaction(int index, Long workflowInstanceKey, String requestId, TransferStatus status, String batchId) { | ||
| String id = String.valueOf(index); | ||
| Date startedAt = new Date(1685536200000L); |
Contributor
There was a problem hiding this comment.
is there a test case available for this?
Contributor
Author
There was a problem hiding this comment.
No, manoj. All data is mocked.
Contributor
Author
There was a problem hiding this comment.
No, it will always send same data. No need for test case here
Contributor
|
Please add description and title for this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[].Format:
[jira_ticket] descriptionex: [phee-123] PR title.
Postman collection PR - [PHEE-637] Added Mock Batch summary collection ph-ee-env-template#411
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Followed the PR title naming convention mentioned above.
Design related bullet points or design document link related to this PR added in the description above.
Updated corresponding Postman Collection or Api documentation for the changes in this PR.
Created/updated unit or integration tests for verifying the changes made.
Added required Swagger annotation and update API documentation with details of any API changes if applicable
Followed the naming conventions as given in https://docs.google.com/document/d/1Q4vaMSzrTxxh9TS0RILuNkSkYCxotuYk1Xe0CMIkkCU/edit?usp=sharing