fix(local-dev): Serviceprovider groupversions changed - #197
Conversation
Signed-off-by: Jakob Bergmeier <jakob.vetter@sap.com>
jakobve
changed the title
maximiliantech
left a comment
maximiliantech
left a comment
There was a problem hiding this comment.
Thanks @jakobve for fixing this 🚀 Just one small comment, see below ⬇️
| name: default | ||
| labels: | ||
| landscaper.services.openmcp.cloud/providertype: default | ||
| landscaper.services.open-control-plane.io/providertype: default |
There was a problem hiding this comment.
I am 99% sure, that we did not change the labels yet. So you would need to revert that line back.
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks! Just out of curiosity, why didn't you change the labels too?
There was a problem hiding this comment.
We wanted to refactor the most critical parts like kind and apiVersion first and to keep the changes as minimal evasive as possible. Refactoring labels should be rather straight forward in theory but throughout the whole codebase we sometimes import/expect labels also in other repositories. Refactoring everything at once would just be too complex. So, right now you will still see "openmcp" in repository names or the codebase.
The goal is to have no "openmcp" (or similar) reference anymore in our project and eventually we will come back to this line of code and refactor it accordingly 👍
Signed-off-by: Jakob Bergmeier <jakob.vetter@sap.com>
2 participants
What this PR does / why we need it:
Release note: