fix: hide Create button in sidebar (both expanded and collapsed states) - #29
Open
GenosseOtt wants to merge 3 commits into
Open
fix: hide Create button in sidebar (both expanded and collapsed states)#29GenosseOtt wants to merge 3 commits into
GenosseOtt wants to merge 3 commits into
Conversation
The expanded sidebar shows a button with text 'Create' inside the MuiDrawer with classes MuiButton-textSecondary + MuiButton-sizeLarge but no aria-label. The existing aria-label selector only caught the collapsed sidebar variant. Add a drawer-scoped selector to hide both. Signed-off-by: Johannes Ott <johannes.ott@sap.com>
Remove aria-label based selectors which break with non-English browsers. Use MUI CSS classes (MuiDrawer-paper + MuiButton-textSecondary + MuiButton-sizeLarge) which are stable across all locales. Signed-off-by: Johannes Ott <johannes.ott@sap.com>
The collapsed sidebar uses MuiIconButton-colorPrimary + MuiIconButton-sizeMedium instead of the text button. Hide both variants with language-independent MUI class selectors. Signed-off-by: Johannes Ott <johannes.ott@sap.com>
GenosseOtt
requested review from
Hubert-Szczepanski-SAP
and removed request for
Lasserich
August 7, 2026 07:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hides the Create button in the Headlamp sidebar in both states:
MuiButton-textSecondary+MuiButton-sizeLarge)MuiIconButton-colorPrimary+MuiIconButton-sizeMedium)Uses language-independent MUI CSS class selectors (no aria-label) so the hiding works regardless of browser locale.