feat: dynamic sidebar tabs - #34
Open
Hubert-Szczepanski-SAP wants to merge 2 commits into
Open
Conversation
When the API group is already live (installed === true), treat the component as Ready regardless of the last phase the host pushed, so a stale or stuck 'Progressing' no longer masks a working component. 'Initializing' and other authoritative phases still win over an unconfirmed probe. Signed-off-by: Hubert-Szczepanski-SAP <hubert.szczepanski@sap.com>
Gate the top-level Crossplane and Flux tabs (registered by separate plugins) on our own install probe: hidden by default, shown once the component's API group is confirmed present, and re-evaluated on a periodic probe so tabs appear/disappear during a session. A sidebar entry filter reads a module-level installed set; the set is refreshed by the probe cycle and the sidebar is re-registered to force Headlamp to recompute only when the set changes. Signed-off-by: Hubert-Szczepanski-SAP <hubert.szczepanski@sap.com>
Contributor
E2E ScreenshotsArtifact: e2e-screenshots
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Dynamically adding components tabs based on installed components