Use Redis for the communication between Server and Engine#1172
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces Redis-based communication between the Server and Engine components, replacing direct HTTP request/response data exchange with a cache-based approach using body access keys.
- Replaces direct request/response body transmission with Redis cache storage and retrieval
- Implements
BodyAccessKeyRequestpattern for referencing cached data via access keys - Adds body converter module registration to both server API and engine components
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/server/worker/src/lib/engine/call-engine.ts | Implements request body caching before engine calls and response retrieval using access keys |
| packages/server/api/src/app/app.ts | Registers the body converter module for Redis-based request/response handling |
| packages/engine/src/main.ts | Updates EngineRequest schema to include requestId and use Type.Unknown for engineInput |
| packages/engine/src/lib/services/progress.service.ts | Modifies progress update requests to use cached request bodies via access keys |
| packages/engine/src/lambda-handler.ts | Updates lambda handler to retrieve request body from cache and return response keys |
| packages/engine/src/engine-executor.ts | Changes engine executor to cache response data and return access keys instead of direct responses |
| packages/engine/src/api-handler.ts | Updates API handler to work with cached request bodies and return access keys |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
MarceloRGonc
requested review from
bigfluffycookie,
maor-rozenfeld and
rita-gorokhod
August 26, 2025 14:30
maor-rozenfeld
approved these changes
Aug 27, 2025
maor-rozenfeld
left a comment
Contributor
There was a problem hiding this comment.
Test the two types of deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Part of OPS-2396.
Additional Notes