Improve data picker performance#1179
Merged
Merged
Conversation
added 4 commits
August 21, 2025 14:41
# Conflicts: # packages/engine/src/lib/services/progress.service.ts # packages/engine/test/services/progress.service.test.ts # packages/server/shared/src/lib/cache/redis-wrapper.ts # packages/server/shared/src/lib/request-oversize-body-handler.ts # packages/server/shared/test/request-oversize-body-handler.test.ts
|
rmn-snpk
marked this pull request as ready for review
August 27, 2025 11:41
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves performance in the data picker component by optimizing how large arrays are processed and rendered. The changes reduce computational overhead through memoization and implement limits on data slicing to prevent excessive UI operations.
- Added memoization to code editor value processing to prevent unnecessary recalculations
- Introduced constants to limit array slicing operations and prevent performance degradation with large datasets
- Replaced magic numbers with named constants for better maintainability
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| code-editor.tsx | Added useMemo to optimize value processing and prevent unnecessary re-renders |
| data-selector-utils.ts | Introduced slice limits and replaced magic numbers with constants to optimize array handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
alexandrudanpop
approved these changes
Aug 27, 2025
rmn-snpk
pushed a commit
that referenced
this pull request
Aug 28, 2025
This reverts commit 02830dc.
rmn-snpk
pushed a commit
that referenced
this pull request
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just added memorization and reduced item big array size in the data picker
Part of OPS-2438.