Restructure analysis results + add visit variable to pool data.frame#362
Open
pengguanya wants to merge 85 commits into
Open
Restructure analysis results + add visit variable to pool data.frame#362pengguanya wants to merge 85 commits into
pengguanya wants to merge 85 commits into
Conversation
Collaborator
Author
Collaborator
Author
Collaborator
|
Hey @pengguanya , Apologies for leaving this so long. Just to say I got around to fixing the issue that was blocking the CICD tests. We also had to create an emergancy update for the package which I've merged into your branch here for you. That being said now that the unit tests are running I am seeing some failures on this PR: The vignettes don't appear to be working: Theres an issue with the document() function but I need to look into that myself. Also looks like some of the snapshot tests have updated which I don't think I was expecting to happen: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



@gowerc @nociale
update based on 255-01
dplyr,rlang,purrrrelated functions to baseassert_thatinstead ofstop_if_notNAvaluesTests are passed for
analyse,analysis_result,ancovaandutilities, but there are still tests and functions (mainlypoolrelevant ones) need to be updated. I will look into that while updatingpoolnext week