fix: ci mod updates - #734
Conversation
Signed-off-by: Anitha Natarajan <anataraj@redhat.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses continuous integration issues and potential timeouts by updating the trigger conditions for the CI image build pipeline. By expanding the trigger to include changes in the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the Tekton pipeline trigger to rebuild the CI image when go.mod is modified. This is a good change, as it ensures the CI environment has the correct dependencies. However, the trigger should also include changes to go.sum, as this file is also critical for defining the exact versions of dependencies and can change even when go.mod does not. I've added a suggestion to include go.sum in the trigger condition to make the CI process more robust.
| annotations: | ||
| pipelinesascode.tekton.dev/on-cel-expression: | | ||
| "Dockerfile.CI".pathChanged() && ( event == "push" || event == "pull_request" ) | ||
| ("Dockerfile.CI".pathChanged() || "go.mod".pathChanged()) && ( event == "push" || event == "pull_request" ) |
There was a problem hiding this comment.
The trigger condition should also include changes to go.sum. The Dockerfile.CI uses both go.mod and go.sum to download Go dependencies. There are scenarios, like updating transitive dependencies, where only go.sum changes. Without triggering a rebuild in this case, the CI could run with stale dependencies from a cached image layer.
("Dockerfile.CI".pathChanged() || "go.mod".pathChanged() || "go.sum".pathChanged()) && ( event == "push" || event == "pull_request" )|
/retest |
|
@srivickynesh everytime CI is failing for PVC or cluster availability. This is not at all scaling. To avoid the release test failures we need to publish the latest images to the openshift-pipeline/ci repo on every PR merge. Do you have any suggestions? |
Update to fix the timeout and ci issue