OCPBUGS-86225: fix PDB AlwaysAllow test failure on IPv6-primary dualstack clusters by tthvo · Pull Request #31196 · openshift/origin

tthvo · 2026-05-20T00:10:24Z

The nginx config in the PDB test only had listen 8080 which binds to IPv4 only. On dualstack clusters where IPv6 is the primary family, the kubelet probes readiness using the pod's IPv6 address. Since nginx was not listening on IPv6, the probe got connection refused and pods never became Ready, causing the test to time out.

Add listen [::]:8080 so nginx accepts connections on both IPv4 and IPv6.

Summary by CodeRabbit

Tests
- Test data updated to include an IPv6 listen directive for port 8080, ensuring test coverage for IPv6 connections alongside IPv4.

openshift-merge-bot · 2026-05-20T00:10:28Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

openshift-ci-robot · 2026-05-20T00:10:31Z

@tthvo: This pull request references Jira Issue OCPBUGS-86225, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (5.0.0) matches configured target version for branch (5.0.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The nginx config in the PDB test only had listen 8080 which binds to IPv4 only. On dualstack clusters where IPv6 is the primary family, the kubelet probes readiness using the pod's IPv6 address. Since nginx was not listening on IPv6, the probe got connection refused and pods never became Ready, causing the test to time out.

Add listen [::]:8080 so nginx accepts connections on both IPv4 and IPv6.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-05-20T00:10:45Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 965a1914-8c95-4153-99b3-1982aba81d48

📥 Commits

Reviewing files that changed from the base of the PR and between cdcd258 and 9596377.

📒 Files selected for processing (2)

test/extended/testdata/bindata.go
test/extended/testdata/poddisruptionbudgets/nginx-with-delayed-ready-deployment.yaml

Walkthrough

A test data file and its generated bindata are updated to add IPv6 listen support to an embedded nginx configuration. The server block now listens on both IPv4 (8080) and IPv6 ([::]:8080) addresses.

Changes

IPv6 listen directive in nginx test deployment

Layer / File(s)	Summary
IPv6 listen directive in nginx config `test/extended/testdata/poddisruptionbudgets/nginx-with-delayed-ready-deployment.yaml`, `test/extended/testdata/bindata.go`	The nginx `default.conf` embedded in the deployment and the generated bindata add an IPv6 listen directive `listen [::]:8080;` to the server block alongside the existing IPv4 directive.

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers:

p0lyn0mial

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Test Structure And Quality	⚠️ Warning	The new Ginkgo test code lacks AfterEach cleanup for created cluster-scoped resources (PDBs, Deployments) and most assertions omit diagnostic messages, violating requirements 2 and 4.	Add AfterEach block to delete created PDB and Deployment resources. Add failure messages to all Expect assertions for better debugging (e.g., Expect(err).NotTo(HaveOccurred(), "failed to create PDB").

✅ Passed checks (11 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title directly addresses the main change: fixing a PDB (PodDisruptionBudget) AlwaysAllow test failure on IPv6-primary dualstack clusters by adding IPv6 listen support to the nginx config.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	All Ginkgo test names in the PR are stable and deterministic with only static strings; no dynamic values, pod names, timestamps, IPs, or generated identifiers are used in test titles.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests added. PR only updates test fixture data (YAML and auto-generated bindata.go). Check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR only modifies test data (nginx config), not new Ginkgo tests. The SNO compatibility check applies only to newly-added tests, which this PR does not contain.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies test data files only, adding IPv6 nginx support. Deployment has no topology-problematic scheduling constraints (no required anti-affinity, nodeSelector, or spread issues).
Ote Binary Stdout Contract	✅ Passed	PR adds only test data files (YAML) and Ginkgo test cases with no process-level stdout writes; all code is within test blocks (It, BeforeEach) which are excluded from the OTE stdout contract.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	New e2e tests have no IPv4-only assumptions, hardcoded IPv4 addresses, or external connectivity requirements. Nginx now listens on both IPv4 and IPv6 ([::]:8080).

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci · 2026-05-20T00:11:00Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tthvo
Once this PR has been reviewed and has the lgtm label, please assign cpmeadors for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2026-05-20T00:11:18Z

@tthvo: This pull request references Jira Issue OCPBUGS-86225, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (5.0.0) matches configured target version for branch (5.0.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

The nginx config in the PDB test only had listen 8080 which binds to IPv4 only. On dualstack clusters where IPv6 is the primary family, the kubelet probes readiness using the pod's IPv6 address. Since nginx was not listening on IPv6, the probe got connection refused and pods never became Ready, causing the test to time out.

Add listen [::]:8080 so nginx accepts connections on both IPv4 and IPv6.

Summary by CodeRabbit

Tests

Updated test infrastructure to support IPv6 connections on port 8080.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tthvo · 2026-05-20T00:12:51Z

/payload-job periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-installer-dualstack-ipv6-primary-techpreview

openshift-ci · 2026-05-20T00:13:03Z

@tthvo: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-installer-dualstack-ipv6-primary-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a463f530-53e0-11f1-9da5-956e57be5815-0

tthvo · 2026-05-20T00:30:52Z

/test okd-scos-images

…tack clusters The nginx config in the PDB test only had `listen 8080` which binds to IPv4 only. On dualstack clusters where IPv6 is the primary family, the kubelet probes readiness using the pod's IPv6 address. Since nginx was not listening on IPv6, the probe got connection refused and pods never became Ready, causing the test to time out. Add `listen [::]:8080` so nginx accepts connections on both IPv4 and IPv6. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

tthvo · 2026-05-20T01:35:05Z

/payload-job periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-installer-dualstack-ipv6-primary-techpreview
/payload-job periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-installer-dualstack-ipv4-primary-techpreview

openshift-ci · 2026-05-20T01:35:08Z

@tthvo: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-installer-dualstack-ipv6-primary-techpreview
periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-installer-dualstack-ipv4-primary-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/213bcaf0-53ec-11f1-8e2a-e6a82cad5655-0

openshift-merge-bot · 2026-05-20T01:56:40Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

tthvo · 2026-05-20T05:23:30Z

Based on the results of 5.0 payload jobs:

The test [sig-apps] poddisruptionbudgets with unhealthyPodEvictionPolicy should evict according to the AlwaysAllow policy [Suite:openshift/conformance/parallel] passed in both AWS dual-stack variants.

openshift-ci · 2026-05-20T06:00:17Z

@tthvo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 20, 2026

openshift-ci Bot requested review from p0lyn0mial and sjenning May 20, 2026 00:10

coderabbitai Bot approved these changes May 20, 2026

View reviewed changes

openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label May 20, 2026

tthvo force-pushed the OCPBUGS-86225 branch from cdcd258 to 9596377 Compare May 20, 2026 01:32

Conversation

tthvo commented May 20, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-merge-bot Bot commented May 20, 2026

Uh oh!

openshift-ci-robot commented May 20, 2026

Uh oh!

coderabbitai Bot commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

openshift-ci Bot commented May 20, 2026

Uh oh!

openshift-ci-robot commented May 20, 2026

Summary by CodeRabbit

Uh oh!

tthvo commented May 20, 2026

Uh oh!

openshift-ci Bot commented May 20, 2026

Uh oh!

tthvo commented May 20, 2026

Uh oh!

tthvo commented May 20, 2026

Uh oh!

openshift-ci Bot commented May 20, 2026

Uh oh!

openshift-merge-bot Bot commented May 20, 2026

Uh oh!

tthvo commented May 20, 2026

Uh oh!

openshift-ci Bot commented May 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tthvo commented May 20, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 20, 2026 •

edited

Loading