Skip to content

[69526] Text overflow in Baseline modal banner #23431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bsatarnejad merged 2 commits into from
Jun 1, 2026
+10 −2
Merged

[69526] Text overflow in Baseline modal banner #23431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54a1190
Wrap enterprise upsell buttons when space is not enough
bsatarnejad May 28, 2026
a6b778d
Undo grid template changes in baseline banner
bsatarnejad May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/components/enterprise_edition/banner_component.sass
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,5 +134,8 @@ $op-enterprise-banner-fixed-height-large: 320px
&--content
padding: var(--base-size-6) var(--base-size-8)

&--upsell-buttons
gap: var(--base-size-8)

&--dismiss
margin-left: var(--controlStack-medium-gap-condensed)
9 changes: 7 additions & 2 deletions app/components/enterprise_edition/upsell_buttons_component.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,19 @@ def initialize(feature_key, show_buy_now: false, **system_arguments)

@system_arguments = system_arguments
@system_arguments[:align_items] ||= :center
@system_arguments[:flex_wrap] ||= :wrap
@system_arguments[:classes] = class_names(
@system_arguments[:classes],
"op-enterprise-banner--upsell-buttons"
)
@feature_key = feature_key
@show_buy_now = show_buy_now
end

def call
flex_layout(**@system_arguments) do |flex|
buttons.each_with_index do |button, i|
flex.with_column(ml: (i == 0 ? 0 : 2)) do
buttons.each do |button|
flex.with_column do
button
end
end
Expand Down
Loading