[72837] Click position is lost when activating an inline edit field#23449
Merged
HDinger merged 2 commits intoJun 2, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses ticket #72837 by preserving the user’s click/cursor position when switching an inplace-edit field from display mode to an inline text input, even though the DOM gets replaced via Turbo Streams.
Changes:
- Introduces a module-level
Mapkeyed bydata-inplace-edit-stable-keyto persist cursor offsets across Turbo Stream replacements. - Captures the character offset on click before requesting the edit field, and restores the selection on controller connect via
setSelectionRange. - Adds helpers to compute a click-based character offset by walking text nodes.
HDinger
force-pushed
the
bug/72837-click-position-is-lost-when-activating-an-inline-edit-field-2
branch
from
311cd5a to
9f4d28a
Compare
myabc
approved these changes
Jun 1, 2026
Contributor
myabc
left a comment
myabc
left a comment
There was a problem hiding this comment.
👍🏻 code looks much better.
One thing that is still not ideal, but doesn't need to block merging: although the caret is placed in the right place when using a standard text input, it may not be visible when there is a long piece of text. I don't know if there is a reliable/cross-browser way to scroll the caret into view?
Screen.Recording.2026-06-01.at.12.24.12.mov
my workaround: use keyboard left/right keys to bring caret into view.
myabc
reviewed
Jun 1, 2026
HDinger
deleted the
bug/72837-click-position-is-lost-when-activating-an-inline-edit-field-2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/72837
What are you trying to accomplish?
Remember click position when switching from display to edit field. Due to the limit of of the
setSelectionRangemethod this only works for inputs of type text.What approach did you choose and why?
On click, the char offset is determined and stored in a module-level Map, keyed by the field's
data-inplace-edit-stable-key. When the edit field controller connects to the rendered input, it reads the stored offset and applies it viasetSelectionRange.