Implement real search_pages for XWiki #23465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft

NobodysNightmare wants to merge 2 commits into dev from xwiki-search

+107 −46

Draft

Implement real search_pages for XWiki #23465

Implement real search_pages for XWiki

GitHub Actions / rubocop failed May 29, 2026 in 0s

reviewdog [rubocop] report

reported by reviewdog 🐶

Findings (3)

modules/wikis/app/services/wikis/adapters/providers/xwiki/queries/concerns/xwiki_query.rb|47 col 77| Prefer single-quoted strings inside interpolations.
modules/wikis/app/services/wikis/adapters/providers/xwiki/queries/concerns/xwiki_query.rb|61 col 21| Do not return in begin..end blocks in assignment contexts.
modules/wikis/app/services/wikis/adapters/providers/xwiki/queries/search_pages.rb|47 col 131| Line is too long. [141/130]

Filtered Findings (0)

Annotations

Check notice on line 47 in modules/wikis/app/services/wikis/adapters/providers/xwiki/queries/concerns/xwiki_query.rb

github-actions / rubocop

[rubocop] modules/wikis/app/services/wikis/adapters/providers/xwiki/queries/concerns/xwiki_query.rb#L47 <Style/StringLiteralsInInterpolation>

Prefer single-quoted strings inside interpolations.

Raw output


            modules/wikis/app/services/wikis/adapters/providers/xwiki/queries/concerns/xwiki_query.rb:47:77: C: Style/StringLiteralsInInterpolation: Prefer single-quoted strings inside interpolations.

Check warning on line 61 in modules/wikis/app/services/wikis/adapters/providers/xwiki/queries/concerns/xwiki_query.rb

github-actions / rubocop

[rubocop] modules/wikis/app/services/wikis/adapters/providers/xwiki/queries/concerns/xwiki_query.rb#L61 <Lint/NoReturnInBeginEndBlocks>

Do not `return` in `begin..end` blocks in assignment contexts.

Raw output


            modules/wikis/app/services/wikis/adapters/providers/xwiki/queries/concerns/xwiki_query.rb:61:21: W: Lint/NoReturnInBeginEndBlocks: Do not `return` in `begin..end` blocks in assignment contexts.

Check notice on line 47 in modules/wikis/app/services/wikis/adapters/providers/xwiki/queries/search_pages.rb

github-actions / rubocop

[rubocop] modules/wikis/app/services/wikis/adapters/providers/xwiki/queries/search_pages.rb#L47 <Layout/LineLength>

Line is too long. [141/130]

Raw output


            modules/wikis/app/services/wikis/adapters/providers/xwiki/queries/search_pages.rb:47:131: C: Layout/LineLength: Line is too long. [141/130]

View more details on GitHub Actions