Register allocator correctness verifier - #13229

Draft

danocmx wants to merge 119 commits into

oracle:masterfrom

danocmx:feat/reg-alloc-verifier

Commits on Mar 22, 2026

Add verifier with phi resolution
danocmx
committed
9a765e2
Handle constants and simple loops
danocmx
committed
09ac5b8
Fix StackSlot as label argument not working
danocmx
committed
d3dc97d
Make sure both previous and current values are present
danocmx
committed
51efb03
Resolve phi variables from usage
danocmx
committed
8692753
Optionally, resolve from jumps
danocmx
committed
ffe73e6
Check for kind constraints
danocmx
committed
3a7a664
Get target register by walking from first usage backwards
danocmx
committed
d80f0b8
Resolve variables from predecessor states
danocmx
committed
cefa342
Fix issues stemming from unit tests
danocmx
committed
25128e7
Make sure speculative instruction is not missed
danocmx
committed
69224db
Resolve more variable locations
danocmx
committed
0775f2a
Store all locations in one Map
danocmx
committed
15eb8a4
Tag constants instead of moving them in FromJump resolver
danocmx
committed
872b321
Fix FromUsage resolver exploding in memory usage
danocmx
committed
b197244
Add readable error messages instead of asserts
danocmx
committed
b40a31d
Check if register can be allocated
danocmx
committed
f48e6d5
Add missing exception
danocmx
committed
6e8dda9
Use correct label instruction for label resolution error
danocmx
committed
d84dd18
Fix logic bug in CircularDefinitionError
danocmx
committed
c767c15
Fix trailing comma in LabelNotResolvedError
danocmx
committed
d260760
Add string representation for RAVInstruction
danocmx
committed
a3bd670
Propagate variables with more accuracy
danocmx
committed
92c489a
Add source to ValueAllocationState
danocmx
committed
37b76d4
Resolve materialized constants to variables
danocmx
committed
3f7060e
Create a materialization conflict resolver
danocmx
committed
2ee75cf
Resolve from usage globally
danocmx
committed
e3f33b2
Extract values from FrameState and verify its contents
danocmx
committed
569612d
Fix typo in ValueNotInRegisterException
danocmx
committed
00aa04a
Make sure variable can rematerialze as constant
danocmx
committed
2ae6469
Add shared state for verifier phases
danocmx
committed
4c7cc15
Remove unused memory map
danocmx
committed
fd9d692
Split resolvers into their own classes
danocmx
committed
499c44d
Use more predecessors to resolve FromJump
danocmx
committed
13fbbf6
Handle canRematerializeToStack for conflict resolution
danocmx
committed
a99f31d
Dump debug file on error
danocmx
committed
cfa4627
Add base Move class
danocmx
committed
040c121
Move register check to AllocationStateMap
danocmx
committed
5ed9c42
Add method selection logic to shared state
danocmx
committed
1bfa592
Flip logic for skipping files
danocmx
committed
7cf409d
Store RAVInstruction as source
danocmx
committed
1659f70
Change LinkedList usage to ArrayList where possible
danocmx
committed
4bec15f
Change line endings to LF
danocmx
committed
76c0091
Fix checkstyle issues
danocmx
committed
ba197a5
Format code
danocmx
committed
88e7d1e
Wrap Value class for data structure indexing
danocmx
committed
ac00e5e
Resolve todos
danocmx
committed
786849a
Make Unknown state create conflicts
danocmx
committed
6f2564f
Save register in exception
danocmx
committed
05a32e6
Add comments to verifer classes
danocmx
committed
a598465
Do not use IllegalStateException
danocmx
committed
89478c1
Check if variable and its alias are equal
danocmx
committed
37dc5e3
Add license header
danocmx
committed
b061de7
Switch instaceof for ValueTool(s)
danocmx
committed
24afdde
Remove old code and do refactoring
danocmx
committed
c7e2528
Add tests for the verifier
danocmx
committed
984a91f
Remove phi resolution option
danocmx
committed
13faefd
Save values from ByteCodeFrame
danocmx
committed
aec2780
Handle allocated stack slot
danocmx
committed
0431f9c
Wrap around allocators
danocmx
committed
5fd14e0
Make stack allocator verification optional
danocmx
committed
4b211b5
Handle callee saved registers
danocmx
committed
b07fce0
Change rav debug file format
danocmx
committed
919995d
Check for java kinds from frames
danocmx
committed
d11b100
Remove block argument in block state
danocmx
committed
e0a266e
Add references list
danocmx
committed
9d641da
Overwrite virtual stack slot in ValueMove
danocmx
committed
225c9a0
Update backup stack slot of a stack move
danocmx
committed
362858d
Fix issues when resolving variables
danocmx
committed
49baaa7
Move vstack to stack conversion for value moves
danocmx
committed
664f145
Fix location warning in RegAllocVerifierTest
danocmx
committed
6b80ecf
Check move kinds against state value being moved
danocmx
committed
8b49f49
Build references before final stage for verification
danocmx
committed
c7b1080
Modify tests to pass verifier
danocmx
committed
25779b4
Add @link to comments
danocmx
committed
12c14aa
Fix warnings from ci
danocmx
committed
8f88fa2
Run eclipse formatter
danocmx
committed
b9febcf
Run style check again
danocmx
committed
0b6de17
Run the formatter again
danocmx
committed
6cfce85
Remove hotspot instructions
danocmx
committed
a47d947
Verify references list
danocmx
committed
ac7a94e

Commits on Mar 23, 2026

Fix derived refs and native pointers
danocmx
committed
6a91b75
Fix warnings from gate
danocmx
committed
3dbe57f
Enable verifier by default for tests
danocmx
committed
2bfa987
Add synonym map for weird virtual move cases
danocmx
committed
1859d38

Commits on Mar 25, 2026

Refactor label variable resolver
danocmx
committed
fbd27b1
Skip register check for prealloc moves
danocmx
committed
c28a22b

Commits on Mar 26, 2026

Handle callee-saved values from virtual moves
danocmx
committed
47b29c3
Check for kinds in value moves
danocmx
committed
1ff83e7
Fix resolver merge state base
danocmx
committed
67b2751
Change synonym map to a conflict resolver
danocmx
committed
6e159b8
Run formatter
danocmx
committed
eb80d21
Remove unused block parameter
danocmx
committed
7d9daf5

Commits on Mar 27, 2026

Commits on Apr 4, 2026

Improve debug file logging
danocmx
committed
68acbac
Add test for infinite loop
danocmx
committed
ea465ec
Add test for callee-saved registers
danocmx
committed
25596b8
Add tests for other exceptions
danocmx
committed
6180508
Fix minor issues
danocmx
committed
689ffd0

Commits on Apr 11, 2026

Make references a set and remove worklist.remove(block)
danocmx
committed
f81cca6
Move ConflictResolver prepare stage
danocmx
committed
615f0c9
Add test for deleted reference
danocmx
committed
715d93b
Fix access to overloaded instruction in exceptions
danocmx
committed
f95f9cf
Add FailOnFirst option
danocmx
committed
54e1cba
Run spellcheck for comments
danocmx
committed
5544c9d
Adjust debuf file output
danocmx
committed
bbb3941
Add missing Override
danocmx
committed
cc4dbe1

Commits on Apr 29, 2026

Changes based on review
danocmx
committed
219c6c1
Fix amr related issues
danocmx
committed
dd401b4

Commits on May 25, 2026

Add changes based on review
danocmx
committed
c7876e9

Commits on Jun 29, 2026

Link conflicted states
danocmx
committed
883d234
Workaround to process state values
danocmx
committed
77c4e08
Switch to priority queue worklist
danocmx
committed
3eb313c
Add optional check for spilled constants
danocmx
committed
e38e057
Add CheckConstRematLocation option
danocmx
committed
d4186b9
Swap value cast order
danocmx
committed
8740900