Remove single-use undeclared composer/pcre dependency with native preg_match - #91
Merged
Merged
Conversation
glaubinix
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The single use of
Composer\Pcre\Preg::isMatchinAbstractApi::parseLinkHeaderrelied oncomposer/pcrebeing available transitively viacomposer/xdebug-handler(a dev dependency offriendsofphp/php-cs-fixer). Downstream projects that installprivate-packagist/api-clientwithout that chain hit a Class "Composer\Pcre\Preg" not found fatal at runtime when paginating any list endpoint.This switches the one call site to native
preg_matchand removes the use import.Trade-off vs. declaring
composer/pcreas a runtime require is thatPreg::isMatchthrows on PCRE errors whilepreg_match(...) === 1returns false on those errors and silently skips the if-block. For this simple regex against a server-generated Link header I personally feel the dependency is unwarranted.