Remove square javapoet references

[ash211]

I'm trying to remove com.squareup:javapoet from my project's dep tree because it contains a perf issue with an unreleased fix: https://github.com/square/javapoet/pull/828

Not much immediate benefit to merging this, and we haven't marked the old versions as deprecated yet, so it's probably not worth rushing this out. But I had the code written, so thought I'd push it.

[changelog-app]

Generate changelog in changelog/@unreleased

What do the change types mean?

• feature: A new feature of the service.
• improvement: An incremental improvement in the functionality or operation of the service.
• fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
• break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
  and external consumers of the service's API (e.g. customer-written software or integrations).
• deprecation: Advertises the intention to remove service functionality without any change to the
  operation of the service itself.
• manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
  performing database surgery, ...) at the time of upgrade for it to succeed.
• migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?

• ❗The break and manual task changelog types will result in a major release!
• 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
• ✨ All others will result in a minor version release.

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

Remove square javapoet references

Check the box to generate changelog(s)

• Generate changelog entry

[pkoenig10]

I'm trying to remove com.squareup:javapoet from my project's dep tree because it contains a perf issue with an unreleased fix.

I don't really understand the motivation here. It may be in your dep tree but as long as you're not using it the perf issue is irrelevant. If there are specific libraries using it that are hitting this perf issue, then the only way to resolve those perf issue is to migrate those libraries.

Removing com.squareup:javapoet from here doesn't really buy us anything and just creates a lot of pain. We have a ton of libraries still using Goethe with com.squareup:javapoet. I don't think it's reasonable to remove this until we have migrated all of them.