Generate TaggedMetricRegistry registry() method#1192
Draft
schlosna wants to merge 2 commits into
Draft
Conversation
Generate changelog in
|
Contributor
|
I could go either way on this, given it's uncommon, it may be reasonable to expect code which unregisters metrics to hold a reference to the original registry as well as the generated *Metrics wrapper. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
The generated metrics classes do not expose a mechanism to interact with the underlying
TaggedMetricRegistry. This is needed for example to unregister metrics.After this PR
==COMMIT_MSG==
Generate TaggedMetricRegistry registry() method
==COMMIT_MSG==
Possible downsides?
This breaks encapsulation of the
TaggedMetricRegistry