Disable renew calls on demand#545
Open
RafalMirowski1 wants to merge 16 commits into
Open
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
bkontur
reviewed
May 21, 2026
| let is_renew_call = name.0.as_slice() == StoragePallet::name().as_bytes() && | ||
| matches!( | ||
| name.1.as_slice(), | ||
| b"renew" | b"force_renew" | b"enable_auto_renew" | b"disable_auto_renew" |
Collaborator
There was a problem hiding this comment.
this is not nice and it is error prone, doesnt pallet_tx_pause support better filtering?
Collaborator
|
@ggwpez if you have some time, could you please also check this usage of tx-pallet? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#542
⏺ Disable renew calls on demand via pallet-tx-pause
Integrates pallet-tx-pause into both bulletin-westend and bulletin-paseo runtimes as a dynamic kill-switch scoped to the renew family of pallet-bulletin-transaction-storage.
What this enables
txPause.pause(("TransactionStorage", "renew")) and the call is rejected at dispatch with frame_system::Error::CallFiltered
What stays unaffected