examples: let chopsticks author past RetentionPeriod#570
Open
x3c41a wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_chopsticks.jsnow overridesTransactionStorage::RetentionPeriodtou32::MAXon the fork and authors several blocks (default 8, override viaCHOPSTICKS_NEW_BLOCKS).Why
Chopsticks can't construct a
TransactionStorageProof(no off-chain chunks), so authoring paststore_block + RetentionPeriodpanics inapply_block_inherentswithStorage proof must be checked once in the block. WithRetentionPeriod = u32::MAX,target_number.saturating_sub(MAX) == 0for every block, soproof_okshort-circuits via thetarget_number.is_zero()branch and no proof is required.Verified
retention=10, store at block 11): control panics at block 21; with override, produced blocks 12–23 cleanly.